Cleanup follow-ups after #419: display-name delete proofs, legacy backfill, reason wording
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 22/100
- Issue 類型
- 缺陷
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- go, kubernetes
研究方向
Read the #419 diff first: it is the precedent for every item here. For item 1, follow the CoderAIProvider sweep for records without a provider ID and the CoderMCPServer live delete path; they should stop deleting on a display-name match and instead keep the record, emit coder_k8s_cleanup_records_unmatched and a ManualCleanupNeeded Event. Item 4 copies the MCP database-switch check so CoderAIProvider reports CoderDeploymentChanged rather than DeletedExternally. Items 2, 3 and 5 need the record/config linking logic before they can be scoped; item 6 is closed, so don't touch it.
由索引模型根據 Issue 內容生成。
描述
Cleanup gaps that remain after #419 (which fixes #353). Each one exists on main before #419 or is a documented limit of it. An independent verifier reproduced items 1 and 3 on main.
- Display-name proofs on delete. The
CoderAIProvidersweep (for a record without a provider ID) and theCoderMCPServerlive delete path still remove a resource whose display name matches the operator's temporary display name. Display names are editable in Coder, so a resource that a person renamed to that pattern can be removed. #413 and #419 adopted the rule "a record without a recorded ID never deletes" for provisioner keys and the MCP sweep. Apply the same rule here: keep the record, surface it (coder_k8s_cleanup_records_unmatched,ManualCleanupNeededEvent), and document manual cleanup. - An MCP config whose slug and display name were both edited after a lost create answer has nothing left that links it to its record. The sweep drops the record and the config stays in Coder.
- Legacy-config backfill. A config made by an older operator version can end up without a record. This happens when the buildinfo read or the record write fails, and then the DELETE fails during the one bounded delete attempt while the control plane is being deleted. Codex thread: https://github.com/coder/coder-k8s/pull/419#discussion_r4427958297
CoderAIProviderreportsDeletedExternallyafter a database switch, whereCoderMCPServernow reportsCoderDeploymentChanged. Nothing leaks, but the reason misleads. Copy the MCP check.- An MCP server whose status lost its config ID stalls with
SlugConflicton its own config. Its delete still uses the recorded ID. #362items 1 and 4 are closed by decision: the control plane hold never ends early, because no signal proves that no dependent cleanup is in flight. Two attempts in #410 were rejected for this reason. Reopen only with such a signal.
Refs #353, #419, #410
Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high
- 主要語言
- Go
- 星號
- 5
- 分支
- 3
- 平均合併
- 2 小時 50 分鐘
- 30 天內合併 PR
- 200
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
coder/coder-k8s 的其他 Issue
-
難度 4/5 3-5 天 新手友好度 45/100
維護者通常 1 天內回覆
-
🤖 perf: pool members read GET /api/v2/users/me on every workspace read, doubling the request budget未關閉
難度 3/5 1-2 天 新手友好度 65/100
維護者通常 1 天內回覆
-
難度 4/5 一週以上 新手友好度 30/100
維護者通常 1 天內回覆
-
Ownership proof for Coder IDs recorded in controller status (D11 B)可能已有人在做 @ThomasK33 於 17 天前認領。 未關閉
coder/coder-k8s#372 · 已指派 1 人 ·
維護者通常 1 天內回覆
-
🤖 Intermittent data race in vendored apiserver secure serving under go test -race可能已有人在做 @ThomasK33 於 19 天前認領。 未關閉
coder/coder-k8s#233 · 1 則留言 · 已指派 1 人 ·
維護者通常 1 天內回覆
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 62/100
維護者通常 2 天內回覆
-
needs-triage
難度 2/5 1-3 小時 新手友好度 62/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 85/100
kagent-dev/kagent#3462 ·
維護者通常 1 天內回覆
-
netrc credential source accepts a password with an embedded CR/LF that every other source rejects未關閉agent-butler-finding bug
難度 2/5 1-3 小時 新手友好度 76/100
jordansmall/spindrift#6268 ·
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 62/100
維護者通常 7 天內回覆