Cleanup follow-ups after #419: display-name delete proofs, legacy backfill, reason wording
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 22/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- go, kubernetes
调研方向
Read the #419 diff first: it is the precedent for every item here. For item 1, follow the CoderAIProvider sweep for records without a provider ID and the CoderMCPServer live delete path; they should stop deleting on a display-name match and instead keep the record, emit coder_k8s_cleanup_records_unmatched and a ManualCleanupNeeded Event. Item 4 copies the MCP database-switch check so CoderAIProvider reports CoderDeploymentChanged rather than DeletedExternally. Items 2, 3 and 5 need the record/config linking logic before they can be scoped; item 6 is closed, so don't touch it.
由索引模型根据 Issue 内容生成。
描述
Cleanup gaps that remain after #419 (which fixes #353). Each one exists on main before #419 or is a documented limit of it. An independent verifier reproduced items 1 and 3 on main.
- Display-name proofs on delete. The
CoderAIProvidersweep (for a record without a provider ID) and theCoderMCPServerlive delete path still remove a resource whose display name matches the operator's temporary display name. Display names are editable in Coder, so a resource that a person renamed to that pattern can be removed. #413 and #419 adopted the rule "a record without a recorded ID never deletes" for provisioner keys and the MCP sweep. Apply the same rule here: keep the record, surface it (coder_k8s_cleanup_records_unmatched,ManualCleanupNeededEvent), and document manual cleanup. - An MCP config whose slug and display name were both edited after a lost create answer has nothing left that links it to its record. The sweep drops the record and the config stays in Coder.
- Legacy-config backfill. A config made by an older operator version can end up without a record. This happens when the buildinfo read or the record write fails, and then the DELETE fails during the one bounded delete attempt while the control plane is being deleted. Codex thread: https://github.com/coder/coder-k8s/pull/419#discussion_r4427958297
CoderAIProviderreportsDeletedExternallyafter a database switch, whereCoderMCPServernow reportsCoderDeploymentChanged. Nothing leaks, but the reason misleads. Copy the MCP check.- An MCP server whose status lost its config ID stalls with
SlugConflicton its own config. Its delete still uses the recorded ID. #362items 1 and 4 are closed by decision: the control plane hold never ends early, because no signal proves that no dependent cleanup is in flight. Two attempts in #410 were rejected for this reason. Reopen only with such a signal.
Refs #353, #419, #410
Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high
- 主要语言
- Go
- 星标
- 5
- 派生
- 3
- 平均合并
- 2 小时 56 分钟
- 30 天内合并 PR
- 185
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
coder/coder-k8s 的其他 Issue
-
难度 4/5 3-5 天 新手友好度 45/100
维护者通常 1 天内回复
-
CoderProvisioner: inherited key-record pruning and legacy-record limits after #420可能已有人在做 @ThomasK33 今天认领。 未关闭
难度 4/5 3-5 天 新手友好度 25/100
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 22/100
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 45/100
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 28/100
维护者通常 1 天内回复
相似的 Issue
-
Headerless responses block while skipping duplicate status lines可能已有人在做 @mynhe 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 73/100
projectdiscovery/rawhttp#554 ·
-
难度 2/5 1-3 小时 新手友好度 80/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 85/100
lognorman20/monaco#7428 ·
-
docs(prompts): IF BLOCKED workflow-scope branch says to comment on the issue on jira/local trackers未关闭agent-butler-finding bug
难度 2/5 1-3 小时 新手友好度 77/100
jordansmall/spindrift#6238 ·
维护者通常 1 天内回复