Remove the old socket path fallback in 0.7.0

Offen
  • Stimmt etwas nicht?
#336 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
35/100
Issue-Typ
Refactoring
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
typescript
Bereich
backend, cli

Rechercherichtung

This is scheduled for the 0.7.0 release branch or the last PR before that release. Start by reading the named functions and calls in src/host/rpcClient.ts, src/host/lifecycle.ts, src/host/socketRoot.ts and src/storage/sessionPaths.ts, then check their unit tests, verification skill entries, and the three named documentation locations. Done means removing the fallback and cleanup support, updating release notes with the 0.5.0 session migration guidance, and passing mise run ci.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

In 0.7.0, remove the fallback to the old socket path that #288 kept.

Why

#288 moved host sockets from /tmp/agent-tty/<8 hex>/<12 hex> to a per-uid root, /tmp/agent-tty-<uid>. 0.6.0 is the first release with the per-uid root. To keep sessions reachable that 0.5.0 or earlier started, this version still connects to the old path and removes leftover sockets there. The code comments plan the removal for 0.7.0.

What to remove

  1. src/host/rpcClient.ts (about line 123): the fallback in sendRpc that connects at legacySocketPath(...).
  2. src/host/lifecycle.ts (about line 443): removeLegacySocketBestEffort and its three calls (about lines 483, 850 and 1213).
  3. src/host/socketRoot.ts (about line 101): isOwnLegacySocket.
  4. src/storage/sessionPaths.ts (about line 183): legacySocketPath.
  5. Their unit tests, and the facts and coverage entries in .agents/skills/verify-session-lifecycle/, if any name these functions.
  6. Docs: docs/USAGE.md limit 2 (about line 391), and the matching lines in src/host/README.md and src/storage/README.md.

When

Trigger: the 0.7.0 release. Do this in the release branch or in the last PR before 0.7.0 is cut, not earlier. Until then, a 0.6.x CLI must still reach a host that 0.5.0 started.

Done when

  • git grep -n -E "legacySocket|isOwnLegacySocket|0\.7\.0" -- src docs finds nothing.
  • The release notes for 0.7.0 say that sessions started by 0.5.0 or earlier can no longer be reached, and that such a session must be destroyed with 0.6.x first.
  • mise run ci passes.

Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high

Vorherrschende Sprache
TypeScript
Sterne
30
Forks
4
Ø Merge
3 Std. 19 Min.
Gemergte PRs (30 T.)
107

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus coder/agent-tty

Alle Issues in coder/agent-tty

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.