Remove the old socket path fallback in 0.7.0

Aperta
#336 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
backend, cli

Direzione di ricerca

This is scheduled for the 0.7.0 release branch or the last PR before that release. Start by reading the named functions and calls in src/host/rpcClient.ts, src/host/lifecycle.ts, src/host/socketRoot.ts and src/storage/sessionPaths.ts, then check their unit tests, verification skill entries, and the three named documentation locations. Done means removing the fallback and cleanup support, updating release notes with the 0.5.0 session migration guidance, and passing mise run ci.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

In 0.7.0, remove the fallback to the old socket path that #288 kept.

Why

#288 moved host sockets from /tmp/agent-tty/<8 hex>/<12 hex> to a per-uid root, /tmp/agent-tty-<uid>. 0.6.0 is the first release with the per-uid root. To keep sessions reachable that 0.5.0 or earlier started, this version still connects to the old path and removes leftover sockets there. The code comments plan the removal for 0.7.0.

What to remove

  1. src/host/rpcClient.ts (about line 123): the fallback in sendRpc that connects at legacySocketPath(...).
  2. src/host/lifecycle.ts (about line 443): removeLegacySocketBestEffort and its three calls (about lines 483, 850 and 1213).
  3. src/host/socketRoot.ts (about line 101): isOwnLegacySocket.
  4. src/storage/sessionPaths.ts (about line 183): legacySocketPath.
  5. Their unit tests, and the facts and coverage entries in .agents/skills/verify-session-lifecycle/, if any name these functions.
  6. Docs: docs/USAGE.md limit 2 (about line 391), and the matching lines in src/host/README.md and src/storage/README.md.

When

Trigger: the 0.7.0 release. Do this in the release branch or in the last PR before 0.7.0 is cut, not earlier. Until then, a 0.6.x CLI must still reach a host that 0.5.0 started.

Done when

  • git grep -n -E "legacySocket|isOwnLegacySocket|0\.7\.0" -- src docs finds nothing.
  • The release notes for 0.7.0 say that sessions started by 0.5.0 or earlier can no longer be reached, and that such a session must be destroyed with 0.6.x first.
  • mise run ci passes.

Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high

Lingua principale
TypeScript
Stelle
30
Fork
4
Merge medio
3h 19m
PR unite (30g)
107

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di coder/agent-tty

Tutte le issue di coder/agent-tty

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.