Remove the old socket path fallback in 0.7.0

未关闭
#336 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
重构
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript
领域
backend, cli

调研方向

This is scheduled for the 0.7.0 release branch or the last PR before that release. Start by reading the named functions and calls in src/host/rpcClient.ts, src/host/lifecycle.ts, src/host/socketRoot.ts and src/storage/sessionPaths.ts, then check their unit tests, verification skill entries, and the three named documentation locations. Done means removing the fallback and cleanup support, updating release notes with the 0.5.0 session migration guidance, and passing mise run ci.

由索引模型根据 Issue 内容生成。

描述

In 0.7.0, remove the fallback to the old socket path that #288 kept.

Why

#288 moved host sockets from /tmp/agent-tty/<8 hex>/<12 hex> to a per-uid root, /tmp/agent-tty-<uid>. 0.6.0 is the first release with the per-uid root. To keep sessions reachable that 0.5.0 or earlier started, this version still connects to the old path and removes leftover sockets there. The code comments plan the removal for 0.7.0.

What to remove

  1. src/host/rpcClient.ts (about line 123): the fallback in sendRpc that connects at legacySocketPath(...).
  2. src/host/lifecycle.ts (about line 443): removeLegacySocketBestEffort and its three calls (about lines 483, 850 and 1213).
  3. src/host/socketRoot.ts (about line 101): isOwnLegacySocket.
  4. src/storage/sessionPaths.ts (about line 183): legacySocketPath.
  5. Their unit tests, and the facts and coverage entries in .agents/skills/verify-session-lifecycle/, if any name these functions.
  6. Docs: docs/USAGE.md limit 2 (about line 391), and the matching lines in src/host/README.md and src/storage/README.md.

When

Trigger: the 0.7.0 release. Do this in the release branch or in the last PR before 0.7.0 is cut, not earlier. Until then, a 0.6.x CLI must still reach a host that 0.5.0 started.

Done when

  • git grep -n -E "legacySocket|isOwnLegacySocket|0\.7\.0" -- src docs finds nothing.
  • The release notes for 0.7.0 say that sessions started by 0.5.0 or earlier can no longer be reached, and that such a session must be destroyed with 0.6.x first.
  • mise run ci passes.

Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high

主要语言
TypeScript
星标
30
派生
4
平均合并
3 小时 19 分钟
30 天内合并 PR
107

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

coder/agent-tty 的其他 Issue

查看 coder/agent-tty 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。