Fix TODOs in the TurboModule implementation

Offen

#30 erstellt am 29.4.2025 0 Kommentare 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@mani3xis arbeitet bereits daran.

Seit 14.5.2025.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Beschreibung

C++

Umbrella for the TODO/FIXME markers left in the C++ TurboModule implementation.

[!NOTE]
The permalinks originally in this issue pointed at react-native-node-api-modules and the pre-rename packages/react-native-node-api-modules/cpp/ paths, so none of them resolved any more. Refreshed below against 29a527d, with each marker mapped to the issue that now covers it.

`CxxNodeApiHostModule.cpp` — `requireNodeAddon` returns `undefined` on bad arguments

https://github.com/callstackincubator/react-native-node-api/blob/29a527d87fa8cb965b0048b1b4c1cff2b0eab281/packages/host/cpp/CxxNodeApiHostModule.cpp#L54-L63

Covered by #50.

`CxxNodeApiHostModule.cpp` — the addon's declared Node-API version is never read

https://github.com/callstackincubator/react-native-node-api/blob/29a527d87fa8cb965b0048b1b4c1cff2b0eab281/packages/host/cpp/CxxNodeApiHostModule.cpp#L127-L131

https://github.com/callstackincubator/react-native-node-api/blob/29a527d87fa8cb965b0048b1b4c1cff2b0eab281/packages/host/cpp/CxxNodeApiHostModule.cpp#L142-L145

Covered by #4 (sub-issue), which also depends on #3 for the napi_module_register half. Both call sites already carry @see links to #4 in the source.

`CxxNodeApiHostModule.hpp` + `AddonLoaders.hpp` — Windows loaders

The LoaderPolicy alias is hardcoded to PosixLoader, so Win32Loader/WinRTLoader are never selected, and all four Windows failure paths detect an error and discard it instead of calling GetLastError():

https://github.com/callstackincubator/react-native-node-api/blob/29a527d87fa8cb965b0048b1b4c1cff2b0eab281/packages/host/cpp/CxxNodeApiHostModule.hpp#L45-L46

https://github.com/callstackincubator/react-native-node-api/blob/29a527d87fa8cb965b0048b1b4c1cff2b0eab281/packages/host/cpp/AddonLoaders.hpp#L45-L100

Covered by #419.

Markers added since this issue was filed

HermesNapiHost.cpp — napi_fatal_exception aborts instead of routing through React Native's error handling → #402
Logger.cpp — log_debug is not compiled out or gated in release builds → #420

Vorherrschende Sprache: TypeScript
Sterne: 188
Forks: 10
Ø Merge: 2 T. 17 Std.
Gemergte PRs (30 T.): 3

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Erste Schritte

Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
Forken Sie das Repository und arbeiten Sie in einem Branch.
Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus callstackincubator/react-native-node-api

Re-enable test-android on main once the self-hosted runner is back Offen

Android 🤖

Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100

callstackincubator/react-native-node-api#379 · Erstellt am 18.7.2026
Sanity check of Hermes source directory via environment variable, when building Android projects Offen

Android 🤖 good first issue

Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100

callstackincubator/react-native-node-api#163 · 1 Kommentar · Erstellt am 08.7.2025
Specify a default C++ standard for generated CMakeLists.txt files Offen

enhancement good first issue gyp-to-cmake

Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100

callstackincubator/react-native-node-api#161 · 3 Kommentare · 1 Reaktion · Erstellt am 08.7.2025
Upstreaming the Node-API host into React Native core ☂️ Offen

enhancement Host 🏡

Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 25/100

callstackincubator/react-native-node-api#447 · Erstellt am 13.8.2026
Two test gaps: unverified prebuild `Info.plist` and a missing `.node` fixture in the Babel plugin tests Offen

Automatable good first issue

Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 15/100

callstackincubator/react-native-node-api#424 · 1 Kommentar · Erstellt am 12.8.2026

Alle Issues in callstackincubator/react-native-node-api

Fix TODOs in the TurboModule implementation

Bewertung

Beschreibung

CxxNodeApiHostModule.cpp — requireNodeAddon returns undefined on bad arguments

CxxNodeApiHostModule.cpp — the addon's declared Node-API version is never read

CxxNodeApiHostModule.hpp + AddonLoaders.hpp — Windows loaders