Fix TODOs in the TurboModule implementation
@mani3xis 已經在處理了。
開始於 2025年5月14日。
評估
這個 Issue 還沒有評估資料。
描述
Umbrella for the TODO/FIXME markers left in the C++ TurboModule implementation.
[!NOTE]
The permalinks originally in this issue pointed atreact-native-node-api-modulesand the pre-renamepackages/react-native-node-api-modules/cpp/paths, so none of them resolved any more. Refreshed below against29a527d, with each marker mapped to the issue that now covers it.
CxxNodeApiHostModule.cpp — requireNodeAddon returns undefined on bad arguments
Covered by #50.
CxxNodeApiHostModule.cpp — the addon's declared Node-API version is never read
https://github.com/callstackincubator/react-native-node-api/blob/29a527d87fa8cb965b0048b1b4c1cff2b0eab281/packages/host/cpp/CxxNodeApiHostModule.cpp#L127-L131
https://github.com/callstackincubator/react-native-node-api/blob/29a527d87fa8cb965b0048b1b4c1cff2b0eab281/packages/host/cpp/CxxNodeApiHostModule.cpp#L142-L145
Covered by #4 (sub-issue), which also depends on #3 for the napi_module_register half. Both call sites already carry @see links to #4 in the source.
CxxNodeApiHostModule.hpp + AddonLoaders.hpp — Windows loaders
The LoaderPolicy alias is hardcoded to PosixLoader, so Win32Loader/WinRTLoader are never selected, and all four Windows failure paths detect an error and discard it instead of calling GetLastError():
Covered by #419.
Markers added since this issue was filed
HermesNapiHost.cpp—napi_fatal_exceptionaborts instead of routing through React Native's error handling → #402Logger.cpp—log_debugis not compiled out or gated in release builds → #420
- 主要語言
- TypeScript
- 星號
- 188
- 分支
- 10
- 平均合併
- 2 天 17 小時
- 30 天內合併 PR
- 3
貢獻指南
這個儲存庫沒有索引到貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
callstackincubator/react-native-node-api 的其他 Issue
-
Android 🤖
難度 2/5 1-3 小時 新手友好度 66/100
-
Sanity check of Hermes source directory via environment variable, when building Android projects 未關閉Android 🤖 good first issue
難度 2/5 1-3 小時 新手友好度 78/100
callstackincubator/react-native-node-api#163 · 1 則留言 ·
-
enhancement good first issue gyp-to-cmake
難度 2/5 1-3 小時 新手友好度 72/100
callstackincubator/react-native-node-api#161 · 3 則留言 · 1 個 reaction ·
-
enhancement Host 🏡
難度 5/5 一週以上 新手友好度 25/100
-
Automatable good first issue
難度 3/5 1-2 天 新手友好度 15/100
callstackincubator/react-native-node-api#424 · 1 則留言 ·
查看 callstackincubator/react-native-node-api 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 75/100
vercel-labs/just-bash#464 ·
-
looksLikeSlug() is ASCII-only, so non-Latin entity slugs (e.g. Korean) skip exact match and collapse 未關閉
難度 2/5 1-3 小時 新手友好度 75/100
-
難度 2/5 1-3 小時 新手友好度 65/100
-
難度 2/5 1-3 小時 新手友好度 65/100
-
難度 1/5 1 小時以內 新手友好度 90/100
TanStack/tanstack.com#1293 ·