Fix TODOs in the TurboModule implementation

未关闭

#30 创建于 2025年4月29日 0 条评论 0 个 reaction 已指派 1 人在 GitHub 查看

@mani3xis 已经在做这个了。

开始于 2025年5月14日。

评估

这个 Issue 还没有评估数据。

描述

C++

Umbrella for the TODO/FIXME markers left in the C++ TurboModule implementation.

[!NOTE]
The permalinks originally in this issue pointed at react-native-node-api-modules and the pre-rename packages/react-native-node-api-modules/cpp/ paths, so none of them resolved any more. Refreshed below against 29a527d, with each marker mapped to the issue that now covers it.

`CxxNodeApiHostModule.cpp` — `requireNodeAddon` returns `undefined` on bad arguments

https://github.com/callstackincubator/react-native-node-api/blob/29a527d87fa8cb965b0048b1b4c1cff2b0eab281/packages/host/cpp/CxxNodeApiHostModule.cpp#L54-L63

Covered by #50.

`CxxNodeApiHostModule.cpp` — the addon's declared Node-API version is never read

https://github.com/callstackincubator/react-native-node-api/blob/29a527d87fa8cb965b0048b1b4c1cff2b0eab281/packages/host/cpp/CxxNodeApiHostModule.cpp#L127-L131

https://github.com/callstackincubator/react-native-node-api/blob/29a527d87fa8cb965b0048b1b4c1cff2b0eab281/packages/host/cpp/CxxNodeApiHostModule.cpp#L142-L145

Covered by #4 (sub-issue), which also depends on #3 for the napi_module_register half. Both call sites already carry @see links to #4 in the source.

`CxxNodeApiHostModule.hpp` + `AddonLoaders.hpp` — Windows loaders

The LoaderPolicy alias is hardcoded to PosixLoader, so Win32Loader/WinRTLoader are never selected, and all four Windows failure paths detect an error and discard it instead of calling GetLastError():

https://github.com/callstackincubator/react-native-node-api/blob/29a527d87fa8cb965b0048b1b4c1cff2b0eab281/packages/host/cpp/CxxNodeApiHostModule.hpp#L45-L46

https://github.com/callstackincubator/react-native-node-api/blob/29a527d87fa8cb965b0048b1b4c1cff2b0eab281/packages/host/cpp/AddonLoaders.hpp#L45-L100

Covered by #419.

Markers added since this issue was filed

HermesNapiHost.cpp — napi_fatal_exception aborts instead of routing through React Native's error handling → #402
Logger.cpp — log_debug is not compiled out or gated in release builds → #420

主要语言: TypeScript
星标: 188
派生: 10
平均合并: 2 天 17 小时
30 天内合并 PR: 3

贡献指南

这个仓库没有索引到贡献指南

从这里开始

先读完整个 Issue，再读项目的贡献指南。
在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
Fork 仓库，在一个分支上完成修改。
提交 Pull Request，并在描述里引用这个 Issue 编号。

callstackincubator/react-native-node-api 的其他 Issue

Re-enable test-android on main once the self-hosted runner is back 未关闭

Android 🤖

难度 2/5 1-3 小时新手友好度 66/100

callstackincubator/react-native-node-api#379 · 2026年7月18日创建
Sanity check of Hermes source directory via environment variable, when building Android projects 未关闭

Android 🤖 good first issue

难度 2/5 1-3 小时新手友好度 78/100

callstackincubator/react-native-node-api#163 · 1 条评论 · 2025年7月8日创建
Specify a default C++ standard for generated CMakeLists.txt files 未关闭

enhancement good first issue gyp-to-cmake

难度 2/5 1-3 小时新手友好度 72/100

callstackincubator/react-native-node-api#161 · 3 条评论 · 1 个 reaction · 2025年7月8日创建
Upstreaming the Node-API host into React Native core ☂️ 未关闭

enhancement Host 🏡

难度 5/5 一周以上新手友好度 25/100

callstackincubator/react-native-node-api#447 · 2026年8月13日创建
Two test gaps: unverified prebuild `Info.plist` and a missing `.node` fixture in the Babel plugin tests 未关闭

Automatable good first issue

难度 3/5 1-2 天新手友好度 15/100

callstackincubator/react-native-node-api#424 · 1 条评论 · 2026年8月12日创建

查看 callstackincubator/react-native-node-api 的全部 Issue

相似的 Issue

VerificationGate: ATTRIBUTION quote guard never matches a normal quotation (\b around the quote) 未关闭

难度 2/5 1-3 小时新手友好度 75/100

danielmiessler/LifeOS#2234 · 2026年9月24日创建
Search with selected text fails: input.value bypasses ngModel, query stays empty 未关闭

T: Bug

难度 2/5 1-3 小时新手友好度 75/100

Eugeny/tabby#11707 · 2026年9月24日创建
Community provider example: OpenHands -> HAL OpenAI-compatible /v1 peer 未关闭

难度 2/5 1-3 小时新手友好度 65/100

OpenHands/OpenHands#17658 · 1 条评论 · 2026年9月24日创建
[Issue] Items that are in Core are referencing IO:AUE 未关闭

难度 1/5 1 小时以内新手友好度 85/100

MegaMek/mekbay#332 · 2026年9月23日创建
CVE-2026-93748 (High) detected in http-cache-semantics-4.1.1.tgz 未关闭

Mend: dependency security vulnerability untriaged

难度 2/5 1-3 小时新手友好度 70/100

opensearch-project/OpenSearch-Dashboards#12806 · 2026年9月23日创建

更多 TypeScript Issue

Fix TODOs in the TurboModule implementation

评估

描述

CxxNodeApiHostModule.cpp — requireNodeAddon returns undefined on bad arguments

CxxNodeApiHostModule.cpp — the addon's declared Node-API version is never read

CxxNodeApiHostModule.hpp + AddonLoaders.hpp — Windows loaders