Feature Request: Time Tracking Permissions

Offen
#342 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Anfängerfreundlichkeit
22/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Bereich
authorization

Rechercherichtung

The request is about restricting what users see in the Time & Projects feature, including organization details, projects, and customers in time reports. Start by reading issue #300, which the author says covers workspace permissions, and check how the existing permission checks are applied on the server. Before any code, the maintainers need to choose between Option 1 (a system-level permission for the whole feature) and Option 2 (per-user visibility of assigned organizations). Done means the chosen option is agreed and server-side checks block the data, not only the UI.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Issue

When you add a user, regardless of their permissions, they can see all configuration in the time tracking time and projects feature. This has the potential to leak sensitive information (such as the hourly rate) when using Windshift as a tenanted system with multiple clients accessing the admin to view work status. I know that https://github.com/Windshiftapp/core/issues/300 resolves the issues around permissions for workspaces, however that Is not the only place that sensitive information could be viewed.

Current Behaviour

  • Every user can see see all organization details and all projects
  • Every user can see all customers in the time tracking reports

Desired Behaviour

The ability to secure the sensitive information in the Time & Projects feature whether that be through feature restrictions or sub-feature permissions.

Option 1:
  • Add in general system permissions to restrict access and visibility to Time & Projects to even see it
  • Access permissions should be validated server-side to ensure data isn't leaked
Option 2:
  • Add in sub feature permissions to only allowed users see assigned organizations
  • Access permissions should be validated server-side to ensure data isn't leaked

Benefits:

This would help make it so that you can invite clients to collaborate on a workspace, but restrict details in the rest of the application that may leak information about other clients and projects and would enhance other permission controls. Option 1 seems like it would be the easiest to implement, as not ever user needs to log or review time, and would make the tool more friendly to direct client collaboration on a workspace.

Vorherrschende Sprache
Go
Sterne
421
Forks
50
Ø Merge
17 Std. 34 Min.
Gemergte PRs (30 T.)
80

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus Windshiftapp/core

Alle Issues in Windshiftapp/core

Ähnliche Issues

Weitere Issues zu Go

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.