Feature Request: Time Tracking Permissions

Ouverte
#342 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
5/5
Temps estimé
Plus d'une semaine
Accessibilité débutants
22/100
Type d'issue
Fonctionnalité
Clarté
Plutôt claire
Activité
Active
Domaine
authorization

Piste de recherche

The request is about restricting what users see in the Time & Projects feature, including organization details, projects, and customers in time reports. Start by reading issue #300, which the author says covers workspace permissions, and check how the existing permission checks are applied on the server. Before any code, the maintainers need to choose between Option 1 (a system-level permission for the whole feature) and Option 2 (per-user visibility of assigned organizations). Done means the chosen option is agreed and server-side checks block the data, not only the UI.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Issue

When you add a user, regardless of their permissions, they can see all configuration in the time tracking time and projects feature. This has the potential to leak sensitive information (such as the hourly rate) when using Windshift as a tenanted system with multiple clients accessing the admin to view work status. I know that https://github.com/Windshiftapp/core/issues/300 resolves the issues around permissions for workspaces, however that Is not the only place that sensitive information could be viewed.

Current Behaviour

  • Every user can see see all organization details and all projects
  • Every user can see all customers in the time tracking reports

Desired Behaviour

The ability to secure the sensitive information in the Time & Projects feature whether that be through feature restrictions or sub-feature permissions.

Option 1:
  • Add in general system permissions to restrict access and visibility to Time & Projects to even see it
  • Access permissions should be validated server-side to ensure data isn't leaked
Option 2:
  • Add in sub feature permissions to only allowed users see assigned organizations
  • Access permissions should be validated server-side to ensure data isn't leaked

Benefits:

This would help make it so that you can invite clients to collaborate on a workspace, but restrict details in the rest of the application that may leak information about other clients and projects and would enhance other permission controls. Option 1 seems like it would be the easiest to implement, as not ever user needs to log or review time, and would make the tool more friendly to direct client collaboration on a workspace.

Langage dominant
Go
Étoiles
421
Forks
50
Merge moyen
17 h 34 min
PR mergées (30 j)
80

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de Windshiftapp/core

Toutes les issues de Windshiftapp/core

Issues similaires

Plus d'issues Go

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.