Feature Request: Time Tracking Permissions

未关闭
#342 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
22/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
领域
authorization

调研方向

The request is about restricting what users see in the Time & Projects feature, including organization details, projects, and customers in time reports. Start by reading issue #300, which the author says covers workspace permissions, and check how the existing permission checks are applied on the server. Before any code, the maintainers need to choose between Option 1 (a system-level permission for the whole feature) and Option 2 (per-user visibility of assigned organizations). Done means the chosen option is agreed and server-side checks block the data, not only the UI.

由索引模型根据 Issue 内容生成。

描述

Issue

When you add a user, regardless of their permissions, they can see all configuration in the time tracking time and projects feature. This has the potential to leak sensitive information (such as the hourly rate) when using Windshift as a tenanted system with multiple clients accessing the admin to view work status. I know that https://github.com/Windshiftapp/core/issues/300 resolves the issues around permissions for workspaces, however that Is not the only place that sensitive information could be viewed.

Current Behaviour

  • Every user can see see all organization details and all projects
  • Every user can see all customers in the time tracking reports

Desired Behaviour

The ability to secure the sensitive information in the Time & Projects feature whether that be through feature restrictions or sub-feature permissions.

Option 1:
  • Add in general system permissions to restrict access and visibility to Time & Projects to even see it
  • Access permissions should be validated server-side to ensure data isn't leaked
Option 2:
  • Add in sub feature permissions to only allowed users see assigned organizations
  • Access permissions should be validated server-side to ensure data isn't leaked

Benefits:

This would help make it so that you can invite clients to collaborate on a workspace, but restrict details in the rest of the application that may leak information about other clients and projects and would enhance other permission controls. Option 1 seems like it would be the easiest to implement, as not ever user needs to log or review time, and would make the tool more friendly to direct client collaboration on a workspace.

主要语言
Go
星标
421
派生
50
平均合并
17 小时 34 分钟
30 天内合并 PR
80

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

Windshiftapp/core 的其他 Issue

查看 Windshiftapp/core 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。