test: check the validator's rules against the reference table

Offen
  • Stimmt etwas nicht?
#23 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
48/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
dart, flutter
Bereich
testing

Rechercherichtung

Compare the Dependency rules table in references/ffca/project_structure.md with the rules map in scripts/validate_layers.dart, noting the known shared mismatch. Study the existing tests in scripts/test/validate_layers_test.dart and the sync_reference.dart --check drift check for the pattern to follow. Done when a test parses the table, fails on drift, and handles the shared row either by waiting for VGVentures/very_good_engineering#292 or by documenting it as a known difference.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

test

Description

The Dependency rules section of references/ffca/project_structure.md says its table "is the whole rule, and it is the version a validation script implements". Nothing checks that the rules map at the top of scripts/validate_layers.dart actually matches that table, so the two can drift apart without anyone noticing.

They already disagree: the table says shared may depend on "external packages only", while the validator allows shared → shared. We believe the reference should change, and that is tracked in Very Good Engineering: VGVentures/very_good_engineering#292.

Requirements

  • A test in scripts/test/validate_layers_test.dart parses the Dependency rules table from references/ffca/project_structure.md and checks it against the validator's rules map.
  • When the table changes upstream and is re-synced, the test fails until the validator is updated.
  • The test lands after the reference is re-synced with VGVentures/very_good_engineering#293, which allows shared → shared and is merged, so no known-difference exception is needed.
  • All CI/CD checks are passing.
  • There is no drop in the test coverage percentage.

Additional Context

This is the drift check sync_reference.dart --check already does for the reference mirror, applied to the validator itself.

Status (2026-10-20): VGVentures/very_good_engineering#293 is merged, but the VGV Engineering site has not redeployed yet. Once the site deploys, run dart run scripts/sync_reference.dart (which also brings in VGVentures/very_good_engineering#297's lib/src/ and data barrel changes), then add this test.

Vorherrschende Sprache
Dart
Sterne
7
Forks
2
Ø Merge
2 T. 8 Std.
Gemergte PRs (30 T.)
9

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus VeryGoodOpenSource/vgv-ffca-plugin

Alle Issues in VeryGoodOpenSource/vgv-ffca-plugin

Ähnliche Issues

Weitere Issues zu Dart

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.