test: check the validator's rules against the reference table

Ouverte
  • Quelque chose ne va pas ?
#23 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
48/100
Type d'issue
Fonctionnalité
Clarté
Plutôt claire
Activité
Active
Stack technique
dart, flutter
Domaine
testing

Piste de recherche

Compare the Dependency rules table in references/ffca/project_structure.md with the rules map in scripts/validate_layers.dart, noting the known shared mismatch. Study the existing tests in scripts/test/validate_layers_test.dart and the sync_reference.dart --check drift check for the pattern to follow. Done when a test parses the table, fails on drift, and handles the shared row either by waiting for VGVentures/very_good_engineering#292 or by documenting it as a known difference.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

test

Description

The Dependency rules section of references/ffca/project_structure.md says its table "is the whole rule, and it is the version a validation script implements". Nothing checks that the rules map at the top of scripts/validate_layers.dart actually matches that table, so the two can drift apart without anyone noticing.

They already disagree: the table says shared may depend on "external packages only", while the validator allows shared → shared. We believe the reference should change, and that is tracked in Very Good Engineering: VGVentures/very_good_engineering#292.

Requirements

  • A test in scripts/test/validate_layers_test.dart parses the Dependency rules table from references/ffca/project_structure.md and checks it against the validator's rules map.
  • When the table changes upstream and is re-synced, the test fails until the validator is updated.
  • The test lands after the reference is re-synced with VGVentures/very_good_engineering#293, which allows shared → shared and is merged, so no known-difference exception is needed.
  • All CI/CD checks are passing.
  • There is no drop in the test coverage percentage.

Additional Context

This is the drift check sync_reference.dart --check already does for the reference mirror, applied to the validator itself.

Status (2026-10-20): VGVentures/very_good_engineering#293 is merged, but the VGV Engineering site has not redeployed yet. Once the site deploys, run dart run scripts/sync_reference.dart (which also brings in VGVentures/very_good_engineering#297's lib/src/ and data barrel changes), then add this test.

Langage dominant
Dart
Étoiles
7
Forks
2
Merge moyen
2 j 8 h
PR mergées (30 j)
9

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de VeryGoodOpenSource/vgv-ffca-plugin

Toutes les issues de VeryGoodOpenSource/vgv-ffca-plugin

Issues similaires

Plus d'issues Dart

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.