test: check the validator's rules against the reference table

Abierto
  • ¿Algo no está bien?
#23 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
48/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
dart, flutter
Área
testing

Línea de trabajo

Compare the Dependency rules table in references/ffca/project_structure.md with the rules map in scripts/validate_layers.dart, noting the known shared mismatch. Study the existing tests in scripts/test/validate_layers_test.dart and the sync_reference.dart --check drift check for the pattern to follow. Done when a test parses the table, fails on drift, and handles the shared row either by waiting for VGVentures/very_good_engineering#292 or by documenting it as a known difference.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

test

Description

The Dependency rules section of references/ffca/project_structure.md says its table "is the whole rule, and it is the version a validation script implements". Nothing checks that the rules map at the top of scripts/validate_layers.dart actually matches that table, so the two can drift apart without anyone noticing.

They already disagree: the table says shared may depend on "external packages only", while the validator allows shared → shared. We believe the reference should change, and that is tracked in Very Good Engineering: VGVentures/very_good_engineering#292.

Requirements

  • A test in scripts/test/validate_layers_test.dart parses the Dependency rules table from references/ffca/project_structure.md and checks it against the validator's rules map.
  • When the table changes upstream and is re-synced, the test fails until the validator is updated.
  • The test lands after the reference is re-synced with VGVentures/very_good_engineering#293, which allows shared → shared and is merged, so no known-difference exception is needed.
  • All CI/CD checks are passing.
  • There is no drop in the test coverage percentage.

Additional Context

This is the drift check sync_reference.dart --check already does for the reference mirror, applied to the validator itself.

Status (2026-10-20): VGVentures/very_good_engineering#293 is merged, but the VGV Engineering site has not redeployed yet. Once the site deploys, run dart run scripts/sync_reference.dart (which also brings in VGVentures/very_good_engineering#297's lib/src/ and data barrel changes), then add this test.

Lenguaje dominante
Dart
Estrellas
7
Forks
2
Merge medio
2 d 8 h
PR fusionados (30 d)
9

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de VeryGoodOpenSource/vgv-ffca-plugin

Todos los issues de VeryGoodOpenSource/vgv-ffca-plugin

Issues similares

Más issues de Dart

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.