--fix: overlap handling, flag combinations and failure modes are untested

Offen
#111 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 2 Tagen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
72/100
Issue-Typ
Feature
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
typescript
Bereich
testing

Rechercherichtung

Read src/lint/fixes.ts and the applyFixes tests in test/fixes.test.ts, then review writeFixes and its CLI tests in src/cli.ts and test/cli.test.ts. Run the documented npm run build && npm test command first. Add tests for the listed overlap, CLI flag, and failure cases; done means the tests pin the expected rewritten files, output, and exit codes.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

help wanted severity: medium testing

Summary

--fix writes user files, but its tests only cover the happy path. The overlap-handling branch in applyFixes, flag combinations, and failure modes are untested.

Where

  • src/lint/fixes.ts:28-31 (overlap skip, including the special case for two identical zero-width insertions)
  • src/cli.ts:233-253 (writeFixes), src/cli.ts:353-357
  • test/fixes.test.ts:83-95 (only roundTrip), plus one plain lint <root> --fix CLI test

Test cases to add

applyFixes:

  • Two findings whose edits overlap: only the first is applied, applied === 1.
  • Two identical zero-width insertions at the same offset: applied once.
  • An insertion at offset X plus a replacement starting at X: the insertion lands before the replacement.
  • Adjacent replacements [a,b] and [b,c]: both applied.
  • Non-ASCII and emoji before the fix range on the same line, and a leading BOM: output pinned. These work today; lock them in.

CLI:

  • --fix run twice: the second run applies 0 fixes and the files are unchanged.
  • --fix --files a.gd: only a.gd is rewritten, even though b.gd has a fixable finding.
  • --fix --changed-since HEAD: only changed files are rewritten.
  • --fix --baseline b.json: pin whether baselined findings are fixed, and that the exit code reflects only the new findings.
  • --fix --fail-on warning where only fixable warnings exist: exit 0 after the fix.
  • A suppressed fixable finding (# gdcorrect-ignore[missing-onready]) is not rewritten.
  • A read-only file (POSIX chmod 444): exit 2 with a clear message, and the other files' writes are reported. Or make the writes all-or-nothing.
  • --fix with --format pretty and --format sarif: the output reflects the rewritten files.

Getting started

  • Relevant files: src/lint/fixes.ts, src/cli.ts, test/fixes.test.ts, test/cli.test.ts
  • How to run tests: npm run build && npm test

Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: M. audit-key: testing|src/lint/fixes.ts|applyFixes

Vorherrschende Sprache
TypeScript
Sterne
0
Forks
6
Ø Merge
1 T. 21 Std.
Gemergte PRs (30 T.)
8

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TMHSDigital/godot-correctness-mcp

Alle Issues in TMHSDigital/godot-correctness-mcp

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.