--fix: overlap handling, flag combinations and failure modes are untested

Ouverte
#111 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 2 jours

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
72/100
Type d'issue
Fonctionnalité
Clarté
Clairement spécifiée
Activité
Active
Stack technique
typescript
Domaine
testing

Piste de recherche

Read src/lint/fixes.ts and the applyFixes tests in test/fixes.test.ts, then review writeFixes and its CLI tests in src/cli.ts and test/cli.test.ts. Run the documented npm run build && npm test command first. Add tests for the listed overlap, CLI flag, and failure cases; done means the tests pin the expected rewritten files, output, and exit codes.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

help wanted severity: medium testing

Summary

--fix writes user files, but its tests only cover the happy path. The overlap-handling branch in applyFixes, flag combinations, and failure modes are untested.

Where

  • src/lint/fixes.ts:28-31 (overlap skip, including the special case for two identical zero-width insertions)
  • src/cli.ts:233-253 (writeFixes), src/cli.ts:353-357
  • test/fixes.test.ts:83-95 (only roundTrip), plus one plain lint <root> --fix CLI test

Test cases to add

applyFixes:

  • Two findings whose edits overlap: only the first is applied, applied === 1.
  • Two identical zero-width insertions at the same offset: applied once.
  • An insertion at offset X plus a replacement starting at X: the insertion lands before the replacement.
  • Adjacent replacements [a,b] and [b,c]: both applied.
  • Non-ASCII and emoji before the fix range on the same line, and a leading BOM: output pinned. These work today; lock them in.

CLI:

  • --fix run twice: the second run applies 0 fixes and the files are unchanged.
  • --fix --files a.gd: only a.gd is rewritten, even though b.gd has a fixable finding.
  • --fix --changed-since HEAD: only changed files are rewritten.
  • --fix --baseline b.json: pin whether baselined findings are fixed, and that the exit code reflects only the new findings.
  • --fix --fail-on warning where only fixable warnings exist: exit 0 after the fix.
  • A suppressed fixable finding (# gdcorrect-ignore[missing-onready]) is not rewritten.
  • A read-only file (POSIX chmod 444): exit 2 with a clear message, and the other files' writes are reported. Or make the writes all-or-nothing.
  • --fix with --format pretty and --format sarif: the output reflects the rewritten files.

Getting started

  • Relevant files: src/lint/fixes.ts, src/cli.ts, test/fixes.test.ts, test/cli.test.ts
  • How to run tests: npm run build && npm test

Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: M. audit-key: testing|src/lint/fixes.ts|applyFixes

Langage dominant
TypeScript
Étoiles
0
Forks
6
Merge moyen
1 j 21 h
PR mergées (30 j)
8

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TMHSDigital/godot-correctness-mcp

Toutes les issues de TMHSDigital/godot-correctness-mcp

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.