--fix: overlap handling, flag combinations and failure modes are untested

Abierto
#111 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
72/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript
Área
testing

Línea de trabajo

Read src/lint/fixes.ts and the applyFixes tests in test/fixes.test.ts, then review writeFixes and its CLI tests in src/cli.ts and test/cli.test.ts. Run the documented npm run build && npm test command first. Add tests for the listed overlap, CLI flag, and failure cases; done means the tests pin the expected rewritten files, output, and exit codes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

help wanted severity: medium testing

Summary

--fix writes user files, but its tests only cover the happy path. The overlap-handling branch in applyFixes, flag combinations, and failure modes are untested.

Where

  • src/lint/fixes.ts:28-31 (overlap skip, including the special case for two identical zero-width insertions)
  • src/cli.ts:233-253 (writeFixes), src/cli.ts:353-357
  • test/fixes.test.ts:83-95 (only roundTrip), plus one plain lint <root> --fix CLI test

Test cases to add

applyFixes:

  • Two findings whose edits overlap: only the first is applied, applied === 1.
  • Two identical zero-width insertions at the same offset: applied once.
  • An insertion at offset X plus a replacement starting at X: the insertion lands before the replacement.
  • Adjacent replacements [a,b] and [b,c]: both applied.
  • Non-ASCII and emoji before the fix range on the same line, and a leading BOM: output pinned. These work today; lock them in.

CLI:

  • --fix run twice: the second run applies 0 fixes and the files are unchanged.
  • --fix --files a.gd: only a.gd is rewritten, even though b.gd has a fixable finding.
  • --fix --changed-since HEAD: only changed files are rewritten.
  • --fix --baseline b.json: pin whether baselined findings are fixed, and that the exit code reflects only the new findings.
  • --fix --fail-on warning where only fixable warnings exist: exit 0 after the fix.
  • A suppressed fixable finding (# gdcorrect-ignore[missing-onready]) is not rewritten.
  • A read-only file (POSIX chmod 444): exit 2 with a clear message, and the other files' writes are reported. Or make the writes all-or-nothing.
  • --fix with --format pretty and --format sarif: the output reflects the rewritten files.

Getting started

  • Relevant files: src/lint/fixes.ts, src/cli.ts, test/fixes.test.ts, test/cli.test.ts
  • How to run tests: npm run build && npm test

Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: M. audit-key: testing|src/lint/fixes.ts|applyFixes

Lenguaje dominante
TypeScript
Estrellas
0
Forks
6
Merge medio
1 d 21 h
PR fusionados (30 d)
8

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/godot-correctness-mcp

Todos los issues de TMHSDigital/godot-correctness-mcp

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.