Bare gdcorrect-ignore that silences a scene finding is reported as unused-suppression
Maintainer antworten meist innerhalb von 2 Tagen
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Anfängerfreundlichkeit
- 76/100
- Issue-Typ
- Bug
- Klarheit
- Klar beschrieben
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- typescript
- Bereich
- testing-qa
Rechercherichtung
Start by reading src/lint/suppressions.ts and the lint and scene reporting flow in src/lint/engine.ts and src/scenes/report.ts; then inspect test/suppressions.test.ts and run npm run build && npm test. Trace how bare directives are counted across lint and scene findings. Done means the repro no longer reports a matched bare directive as unused, unmatched bare directives still are reported, and the node-path suggestion names scene-node-path-missing.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Summary
A bare # gdcorrect-ignore (no rule list) in a .gd file that silences a scene or project finding is reported by the lint pass as unused-suppression. The tool's own suggestion for scene-node-path-missing tells users to write exactly that comment.
Where
src/lint/suppressions.ts:82(the out-of-scope exemption only applies whend.rulesis non-null)src/lint/engine.ts:32-40src/scenes/node-paths.ts:119(suggestion: "suppress with # gdcorrect-ignore")src/scenes/input-actions.ts:89
Details
if (d.used) continue;
if (d.rules && [...d.rules].every(outOfScope)) continue; // bare directive: rules === null -> reported
The scene passes honor the directive with reportUnused=false. The lint pass never sees those scene findings, so it treats the bare directive as unused.
Impact
Following the tool's advice produces a new finding. report shows unused-suppression for a directive that did suppress something, and --fail-on info (or a severity override on that rule) fails the run. Introduced with 2e316b6.
Steps to reproduce
- In a scene-attached script
main.gd, inside_ready, add$Spawned.show() # gdcorrect-ignore(whereSpawnedis not in the scene) andif Input.is_action_pressed("jmp"): # gdcorrect-ignore. - Run
gdcorrect report <project> --format pretty. Both lines getINFO unused-suppression, and the scene findings are (correctly) hidden.
Suggested fix
Pick one:
- Do the unused-suppression bookkeeping once per file over the combined lint and scene/project findings.
- Have the lint pass leave bare directives on lines containing a node-path literal or an input-action call unreported.
In either case, change the node-path suggestion to recommend # gdcorrect-ignore[scene-node-path-missing].
Acceptance criteria
- The repro produces no
unused-suppressionfindings. - A bare directive that matches nothing in any pass is still reported.
Getting started
- Relevant files:
src/lint/suppressions.ts,src/lint/engine.ts,src/scenes/report.ts,test/suppressions.test.ts - How to run tests:
npm run build && npm test
Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: M. audit-key: bug|src/lint/suppressions.ts|applySuppressions
- Vorherrschende Sprache
- TypeScript
- Sterne
- 0
- Forks
- 6
- Ø Merge
- 1 T. 21 Std.
- Gemergte PRs (30 T.)
- 8
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus TMHSDigital/godot-correctness-mcp
-
enhancement good first issue severity: medium
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 85/100
TMHSDigital/godot-correctness-mcp#123 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
dependencies good first issue severity: low
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
TMHSDigital/godot-correctness-mcp#116 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
bug good first issue severity: low
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 88/100
TMHSDigital/godot-correctness-mcp#107 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
bug good first issue severity: low
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 85/100
TMHSDigital/godot-correctness-mcp#106 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
bug good first issue severity: medium
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 84/100
TMHSDigital/godot-correctness-mcp#105 ·
Maintainer antworten meist innerhalb von 2 Tagen
Alle Issues in TMHSDigital/godot-correctness-mcp
Ähnliche Issues
-
clawsweeper:needs-maintainer-review clawsweeper:needs-product-decision clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster P3
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
openclaw/openclaw#203385 · 1 Kommentar · 1 Reaktion ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
nwverse/persona#12800 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 80/100
Maintainer antworten meist innerhalb von 1 Tag
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
microsoft/playwright#44289 ·
Maintainer antworten meist innerhalb von 1 Tag
-
good first issue
Schwierigkeit 2/5 Ein halber Tag Anfängerfreundlichkeit 65/100
Maintainer antworten meist innerhalb von 1 Tag