Bare gdcorrect-ignore that silences a scene finding is reported as unused-suppression

Ouverte
#102 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 2 jours

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
76/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
typescript
Domaine
testing-qa

Piste de recherche

Start by reading src/lint/suppressions.ts and the lint and scene reporting flow in src/lint/engine.ts and src/scenes/report.ts; then inspect test/suppressions.test.ts and run npm run build && npm test. Trace how bare directives are counted across lint and scene findings. Done means the repro no longer reports a matched bare directive as unused, unmatched bare directives still are reported, and the node-path suggestion names scene-node-path-missing.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug severity: medium

Summary

A bare # gdcorrect-ignore (no rule list) in a .gd file that silences a scene or project finding is reported by the lint pass as unused-suppression. The tool's own suggestion for scene-node-path-missing tells users to write exactly that comment.

Where

  • src/lint/suppressions.ts:82 (the out-of-scope exemption only applies when d.rules is non-null)
  • src/lint/engine.ts:32-40
  • src/scenes/node-paths.ts:119 (suggestion: "suppress with # gdcorrect-ignore")
  • src/scenes/input-actions.ts:89

Details

if (d.used) continue;
if (d.rules && [...d.rules].every(outOfScope)) continue;   // bare directive: rules === null -> reported

The scene passes honor the directive with reportUnused=false. The lint pass never sees those scene findings, so it treats the bare directive as unused.

Impact

Following the tool's advice produces a new finding. report shows unused-suppression for a directive that did suppress something, and --fail-on info (or a severity override on that rule) fails the run. Introduced with 2e316b6.

Steps to reproduce

  1. In a scene-attached script main.gd, inside _ready, add $Spawned.show() # gdcorrect-ignore (where Spawned is not in the scene) and if Input.is_action_pressed("jmp"): # gdcorrect-ignore.
  2. Run gdcorrect report <project> --format pretty. Both lines get INFO unused-suppression, and the scene findings are (correctly) hidden.

Suggested fix

Pick one:

  • Do the unused-suppression bookkeeping once per file over the combined lint and scene/project findings.
  • Have the lint pass leave bare directives on lines containing a node-path literal or an input-action call unreported.

In either case, change the node-path suggestion to recommend # gdcorrect-ignore[scene-node-path-missing].

Acceptance criteria

  • The repro produces no unused-suppression findings.
  • A bare directive that matches nothing in any pass is still reported.

Getting started

  • Relevant files: src/lint/suppressions.ts, src/lint/engine.ts, src/scenes/report.ts, test/suppressions.test.ts
  • How to run tests: npm run build && npm test

Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: M. audit-key: bug|src/lint/suppressions.ts|applySuppressions

Langage dominant
TypeScript
Étoiles
0
Forks
6
Merge moyen
1 j 21 h
PR mergées (30 j)
8

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TMHSDigital/godot-correctness-mcp

Toutes les issues de TMHSDigital/godot-correctness-mcp

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.