Bare gdcorrect-ignore that silences a scene finding is reported as unused-suppression
I maintainer di solito rispondono entro 2 giorni
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 76/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- typescript
- Ambito
- testing-qa
Direzione di ricerca
Start by reading src/lint/suppressions.ts and the lint and scene reporting flow in src/lint/engine.ts and src/scenes/report.ts; then inspect test/suppressions.test.ts and run npm run build && npm test. Trace how bare directives are counted across lint and scene findings. Done means the repro no longer reports a matched bare directive as unused, unmatched bare directives still are reported, and the node-path suggestion names scene-node-path-missing.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
A bare # gdcorrect-ignore (no rule list) in a .gd file that silences a scene or project finding is reported by the lint pass as unused-suppression. The tool's own suggestion for scene-node-path-missing tells users to write exactly that comment.
Where
src/lint/suppressions.ts:82(the out-of-scope exemption only applies whend.rulesis non-null)src/lint/engine.ts:32-40src/scenes/node-paths.ts:119(suggestion: "suppress with # gdcorrect-ignore")src/scenes/input-actions.ts:89
Details
if (d.used) continue;
if (d.rules && [...d.rules].every(outOfScope)) continue; // bare directive: rules === null -> reported
The scene passes honor the directive with reportUnused=false. The lint pass never sees those scene findings, so it treats the bare directive as unused.
Impact
Following the tool's advice produces a new finding. report shows unused-suppression for a directive that did suppress something, and --fail-on info (or a severity override on that rule) fails the run. Introduced with 2e316b6.
Steps to reproduce
- In a scene-attached script
main.gd, inside_ready, add$Spawned.show() # gdcorrect-ignore(whereSpawnedis not in the scene) andif Input.is_action_pressed("jmp"): # gdcorrect-ignore. - Run
gdcorrect report <project> --format pretty. Both lines getINFO unused-suppression, and the scene findings are (correctly) hidden.
Suggested fix
Pick one:
- Do the unused-suppression bookkeeping once per file over the combined lint and scene/project findings.
- Have the lint pass leave bare directives on lines containing a node-path literal or an input-action call unreported.
In either case, change the node-path suggestion to recommend # gdcorrect-ignore[scene-node-path-missing].
Acceptance criteria
- The repro produces no
unused-suppressionfindings. - A bare directive that matches nothing in any pass is still reported.
Getting started
- Relevant files:
src/lint/suppressions.ts,src/lint/engine.ts,src/scenes/report.ts,test/suppressions.test.ts - How to run tests:
npm run build && npm test
Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: M. audit-key: bug|src/lint/suppressions.ts|applySuppressions
- Lingua principale
- TypeScript
- Stelle
- 0
- Fork
- 6
- Merge medio
- 1g 21h
- PR unite (30g)
- 8
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di TMHSDigital/godot-correctness-mcp
-
enhancement good first issue severity: medium
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
TMHSDigital/godot-correctness-mcp#123 ·
I maintainer di solito rispondono entro 2 giorni
-
dependencies good first issue severity: low
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
TMHSDigital/godot-correctness-mcp#116 ·
I maintainer di solito rispondono entro 2 giorni
-
bug good first issue severity: low
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
TMHSDigital/godot-correctness-mcp#107 ·
I maintainer di solito rispondono entro 2 giorni
-
bug good first issue severity: low
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
TMHSDigital/godot-correctness-mcp#106 ·
I maintainer di solito rispondono entro 2 giorni
-
bug good first issue severity: medium
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
TMHSDigital/godot-correctness-mcp#105 ·
I maintainer di solito rispondono entro 2 giorni
Tutte le issue di TMHSDigital/godot-correctness-mcp
Issue simili
-
clawsweeper:needs-maintainer-review clawsweeper:needs-product-decision clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster P3
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
openclaw/openclaw#203385 · 1 commento · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
nwverse/persona#12800 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
I maintainer di solito rispondono entro 1 giorno
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
microsoft/playwright#44289 ·
I maintainer di solito rispondono entro 1 giorno
-
good first issue
Difficoltà 2/5 Mezza giornata Idoneità per principianti 65/100
I maintainer di solito rispondono entro 1 giorno