Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

Issues with Insiders changes and themes

Offen
#129 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
25/100
Issue-Typ
Bug
Klarheit
Muss geklärt werden
Aktivitätsstatus
Veraltet
Tech-Stack
powershell
Bereich
tooling

Rechercherichtung

No repository files or tests are named. Start by reproducing the difference between VSCode 1.26.0-insider and the stable branch with Microsoft's Monokai and the screenshots' syntax examples, then trace the syntax-scoping changes affecting themes. Done means the relevant syntax renders consistently in Insiders and stable without requiring theme-specific fixes.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Environment
  • Editor and Version (VS Code, Atom, Sublime): VSCode 1.26.0-insider
  • Your primary theme: Microsoft's Monokai
Issue Description

With the changes to the syntax it breaks most every theme. I have had to revert to the stable branch because I can't find a usable theme that doesn't mess with my eyes. A change like this was attempted in the past, and had to be reverted. I think @daviwil and @gravejester can give more details on some of those.

If you want to correct the syntax and make the scoping right, you need to have the major themes supporting it and looking how users expect before you roll out the changes to the syntax. This has been a major disruption in my work. I spent half my workday trying to get my editor to look decent enough to get back to work, and eventually had to revert to stable, but that won't always be an option.

I don't think telling users to submit a pull request to fix a theme is the appropriate way to handle this. I can't think of many powershell users who may know how to even go about adding support to the theme they use. This syntax is a tool that people use to make a living.

Screenshots

Insiders
2018-08-13_10-51-17

Stable
2018-08-13_10-52-55

Insiders
2018-08-13_11-00-08

Stable
2018-08-13_10-59-30

Insiders
2018-08-13_11-00-57

Stable
2018-08-13_11-01-30

Expected Behavior

Users expect the themes to look how they currently look. There is very little that looks the same between insiders and stable. The only thing that stands out that is the same is basic strings.

If you can't implement fixes without breaking every theme, then I don't think you should push this until you can come up with a better way to roll these out without impacting every single powershell user. If these changes have to go through, then at the very least make sure the most popular themes will look the same as they do now.

Vorherrschende Sprache
PowerShell
Sterne
151
Forks
55
Keine gemergten PRs in 30 T.

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus PowerShell/EditorSyntax

Alle Issues in PowerShell/EditorSyntax

Ähnliche Issues

Weitere Issues zu DevTools

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.