Issues with Insiders changes and themes
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 25/100
- Issue 類型
- 缺陷
- 描述清晰度
- 需要釐清
- 活躍度
- 停滯
- 技術堆疊
- powershell
- 領域
- tooling
研究方向
No repository files or tests are named. Start by reproducing the difference between VSCode 1.26.0-insider and the stable branch with Microsoft's Monokai and the screenshots' syntax examples, then trace the syntax-scoping changes affecting themes. Done means the relevant syntax renders consistently in Insiders and stable without requiring theme-specific fixes.
由索引模型根據 Issue 內容生成。
描述
Environment
- Editor and Version (VS Code, Atom, Sublime): VSCode 1.26.0-insider
- Your primary theme: Microsoft's Monokai
Issue Description
With the changes to the syntax it breaks most every theme. I have had to revert to the stable branch because I can't find a usable theme that doesn't mess with my eyes. A change like this was attempted in the past, and had to be reverted. I think @daviwil and @gravejester can give more details on some of those.
If you want to correct the syntax and make the scoping right, you need to have the major themes supporting it and looking how users expect before you roll out the changes to the syntax. This has been a major disruption in my work. I spent half my workday trying to get my editor to look decent enough to get back to work, and eventually had to revert to stable, but that won't always be an option.
I don't think telling users to submit a pull request to fix a theme is the appropriate way to handle this. I can't think of many powershell users who may know how to even go about adding support to the theme they use. This syntax is a tool that people use to make a living.
Screenshots
Insiders

Stable

Insiders

Stable

Insiders

Stable

Expected Behavior
Users expect the themes to look how they currently look. There is very little that looks the same between insiders and stable. The only thing that stands out that is the same is basic strings.
If you can't implement fixes without breaking every theme, then I don't think you should push this until you can come up with a better way to roll these out without impacting every single powershell user. If these changes have to go through, then at the very least make sure the most popular themes will look the same as they do now.
- 主要語言
- PowerShell
- 星號
- 151
- 分支
- 55
- PR 合併指標
- 30 天內沒有已合併 PR
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
PowerShell/EditorSyntax 的其他 Issue
-
難度 3/5 1-2 天 新手友好度 55/100
PowerShell/EditorSyntax#224 · 2 則留言 ·
-
難度 3/5 1-2 天 新手友好度 48/100
PowerShell/EditorSyntax#222 · 2 則留言 ·
-
難度 3/5 1-2 天 新手友好度 55/100
PowerShell/EditorSyntax#221 · 2 則留言 ·
-
難度 3/5 1-2 天 新手友好度 45/100
PowerShell/EditorSyntax#220 · 2 則留言 · 1 個 reaction ·
-
Issue-Bug
難度 3/5 1-2 天 新手友好度 48/100
PowerShell/EditorSyntax#219 · 2 則留言 ·
查看 PowerShell/EditorSyntax 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 75/100
-
難度 2/5 1-3 小時 新手友好度 75/100
nightscout/nocturne#1424 ·
-
A claim comment carrying the issue number is silently declined while the workflow reports success 未關閉area: repo bug perceived difficulty: 2
難度 2/5 1-3 小時 新手友好度 70/100
-
難度 2/5 1-3 小時 新手友好度 65/100
paritytech/zombienet-sdk#591 ·
-
bug
難度 2/5 1-3 小時 新手友好度 75/100
mruangutai/harness#1897 ·