Hacktoberfest 2026:メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Issues with Insiders changes and themes

オープン
#129 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
25/100
issue の種類
バグ
明瞭さ
説明が足りない
活発さ
停滞
技術スタック
powershell
領域
tooling

調査の方向性

No repository files or tests are named. Start by reproducing the difference between VSCode 1.26.0-insider and the stable branch with Microsoft's Monokai and the screenshots' syntax examples, then trace the syntax-scoping changes affecting themes. Done means the relevant syntax renders consistently in Insiders and stable without requiring theme-specific fixes.

索引モデルが issue の本文から書いたものです。

説明

Environment
  • Editor and Version (VS Code, Atom, Sublime): VSCode 1.26.0-insider
  • Your primary theme: Microsoft's Monokai
Issue Description

With the changes to the syntax it breaks most every theme. I have had to revert to the stable branch because I can't find a usable theme that doesn't mess with my eyes. A change like this was attempted in the past, and had to be reverted. I think @daviwil and @gravejester can give more details on some of those.

If you want to correct the syntax and make the scoping right, you need to have the major themes supporting it and looking how users expect before you roll out the changes to the syntax. This has been a major disruption in my work. I spent half my workday trying to get my editor to look decent enough to get back to work, and eventually had to revert to stable, but that won't always be an option.

I don't think telling users to submit a pull request to fix a theme is the appropriate way to handle this. I can't think of many powershell users who may know how to even go about adding support to the theme they use. This syntax is a tool that people use to make a living.

Screenshots

Insiders
2018-08-13_10-51-17

Stable
2018-08-13_10-52-55

Insiders
2018-08-13_11-00-08

Stable
2018-08-13_10-59-30

Insiders
2018-08-13_11-00-57

Stable
2018-08-13_11-01-30

Expected Behavior

Users expect the themes to look how they currently look. There is very little that looks the same between insiders and stable. The only thing that stands out that is the same is basic strings.

If you can't implement fixes without breaking every theme, then I don't think you should push this until you can come up with a better way to roll these out without impacting every single powershell user. If these changes have to go through, then at the very least make sure the most popular themes will look the same as they do now.

主要言語
PowerShell
スター
151
フォーク
55
PR マージ指標
30日以内にマージされた PR はありません

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

PowerShell/EditorSyntax のほかの issue

PowerShell/EditorSyntax の issue をすべて見る

似ている issue

DevTools の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。