Bitter Dead Explosion should scale with SPELL modifiers (increased spell damage/spell critical hit chance/spell critical damage bonus)

Offen
#2,567 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
56/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
lua
Bereich
backend, game-dev

Rechercherichtung

Start by locating the Bitter Dead Explosion damage calculation and compare how it applies generic, elemental, and spell modifiers. Check the relevant damage calculation tests or add a focused case if none is mentioned in the project; done when spell damage, spell critical chance, and spell critical damage modifiers affect the result as described while existing modifiers continue to work.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

In game, Bitter Dead Explosion damage does scale with spell modifiers such as "increased spell damage", "% increased Critical Damage Bonus" and "% increased Critical Spell Damage Bonus".

What is the value from the calculation in Path of Building?

In Path of Building, the damage does not scale with spell modifiers.
It does scale correctly with generic crit, cold damage, lightning damage, elemental damage.

How to reproduce the issue

No response

PoB for PoE2 build code
0.23.1-bb52d6b36
Screenshots

No response

Vorherrschende Sprache
Lua
Sterne
1.9k
Forks
469
Ø Merge
3 Min.
Gemergte PRs (30 T.)
1

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus PathOfBuildingCommunity/PathOfBuilding-PoE2

Alle Issues in PathOfBuildingCommunity/PathOfBuilding-PoE2

Ähnliche Issues

Weitere Issues zu Lua

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.