pstops re-applies the PPD's default output order after pdftopdf, inverting explicit `outputorder` on face-up PostScript queues

Offen
#119 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
48/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
c
Bereich
backend

Rechercherichtung

The filter chain drops OutputOrder in ppd/pdftops.c (ppdFilterPDFToPS, around L77–L91 and L595), and pstops then falls back to the PPD default in ppd/imagetops-pstops.c (around L4257–L4275, applied near L4385). Start by reproducing with cupsfilter -p ps.ppd -m application/vnd.cups-postscript -o outputorder=reverse test.pdf and the sample face-up OutputBin PPD. Done means explicit normal/reverse survives pstops while the PPD default applies only when the job omits outputorder, coordinated with libcupsfilters#366.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

This issue was found by Claude while preparing https://github.com/OpenPrinting/libcupsfilters/pull/366.


Describe the bug

On a PostScript PPD queue whose default output bin has *PageStackOrder ...: Reverse (or that has *DefaultOutputOrder: Reverse), an explicit output order in the job comes out inverted. pdftopdf applies the requested order, and then pstops reverses the pages again because of the PPD default.

Job option Printed order (3-page document)
none 3, 2, 1 (correct)
outputorder=reverse 1, 2, 3
outputorder=normal 3, 2, 1

To Reproduce

  1. Take a generic PostScript PPD, e.g. /usr/lib/cups/daemon/cups-driverd cat drv:///sample.drv/generic.ppd > ps.ppd, and append a face-up output bin:

    *OpenUI *OutputBin/Output Tray: PickOne
    *OrderDependency: 10 AnySetup *OutputBin
    *DefaultOutputBin: FaceUp
    *OutputBin FaceUp/Face Up: ""
    *PageStackOrder FaceUp: Reverse
    *CloseUI: *OutputBin
    
  2. Run a 3-page PDF with numbered pages through the filter chain (pdftopdf, pdftops):

    cupsfilter -p ps.ppd -m application/vnd.cups-postscript -o outputorder=reverse test.pdf > out.ps
    
  3. See the pages in out.ps come out as 1, 2, 3. With -o outputorder=normal they come out as 3, 2, 1.

Running the pdftopdf and pdftops filters by hand with PPD=ps.ppd gives the same result. *DefaultOutputOrder: Reverse instead of the output bin behaves the same way.

Expected behavior

An explicit outputorder=reverse prints the pages in reverse order and outputorder=normal in normal order, as on queues without a reverse default. The PPD's default order should only apply when the job doesn't ask for one.

Screenshots

No screenshots; the relevant log line from cupsfilter with outputorder=reverse shows pstops reversing the already reversed pages:

DEBUG: ppdFilterPSToPS: slow_collate=0, slow_duplex=0, slow_order=1

System Information:

  • OS: Arch Linux
  • Version: libppd 2.1.1 (libppd master 93ed8499 has the same code)
  • Version of CUPS, libcupsfilters, ...: CUPS 2.4.20, cups-filters 2.0.1, libcupsfilters 2.2.1 (git 3bf18925) and master 89e4c33a with OpenPrinting/libcupsfilters#366

Additional context

When pdftopdf has run, ppdFilterPDFToPS() drops OutputOrder from the pstops options (pdftops.c L77–L91, L595). pstops then treats the missing option as "use the PPD default" (imagetops-pstops.c L4257–L4275) and reverses again (L4385).

Suggested fix: pass OutputOrder=Normal to pstops instead of dropping it, as Collate=True is added back (L609–L617). This needs coordinating with OpenPrinting/libcupsfilters#366, which leaves the default order of PostScript PPD queues to pstops because of this bug. A pdftopdf marker like %%PDFTOPDFNumCopies could tell libppd when pdftopdf has applied the order, so mixed versions keep working. Happy to help with either side.

Tested with the generic PPD above, not on a physical face-up PostScript printer.

Vorherrschende Sprache
C
Sterne
6
Forks
38
Ø Merge
16 Std. 30 Min.
Gemergte PRs (30 T.)
25

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus OpenPrinting/libppd

Alle Issues in OpenPrinting/libppd

Ähnliche Issues

Weitere Issues zu C

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.