pstops re-applies the PPD's default output order after pdftopdf, inverting explicit `outputorder` on face-up PostScript queues

オープン
#119 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
c
領域
backend

調査の方向性

The filter chain drops OutputOrder in ppd/pdftops.c (ppdFilterPDFToPS, around L77–L91 and L595), and pstops then falls back to the PPD default in ppd/imagetops-pstops.c (around L4257–L4275, applied near L4385). Start by reproducing with cupsfilter -p ps.ppd -m application/vnd.cups-postscript -o outputorder=reverse test.pdf and the sample face-up OutputBin PPD. Done means explicit normal/reverse survives pstops while the PPD default applies only when the job omits outputorder, coordinated with libcupsfilters#366.

索引モデルが issue の本文から書いたものです。

説明

This issue was found by Claude while preparing https://github.com/OpenPrinting/libcupsfilters/pull/366.


Describe the bug

On a PostScript PPD queue whose default output bin has *PageStackOrder ...: Reverse (or that has *DefaultOutputOrder: Reverse), an explicit output order in the job comes out inverted. pdftopdf applies the requested order, and then pstops reverses the pages again because of the PPD default.

Job option Printed order (3-page document)
none 3, 2, 1 (correct)
outputorder=reverse 1, 2, 3
outputorder=normal 3, 2, 1

To Reproduce

  1. Take a generic PostScript PPD, e.g. /usr/lib/cups/daemon/cups-driverd cat drv:///sample.drv/generic.ppd > ps.ppd, and append a face-up output bin:

    *OpenUI *OutputBin/Output Tray: PickOne
    *OrderDependency: 10 AnySetup *OutputBin
    *DefaultOutputBin: FaceUp
    *OutputBin FaceUp/Face Up: ""
    *PageStackOrder FaceUp: Reverse
    *CloseUI: *OutputBin
    
  2. Run a 3-page PDF with numbered pages through the filter chain (pdftopdf, pdftops):

    cupsfilter -p ps.ppd -m application/vnd.cups-postscript -o outputorder=reverse test.pdf > out.ps
    
  3. See the pages in out.ps come out as 1, 2, 3. With -o outputorder=normal they come out as 3, 2, 1.

Running the pdftopdf and pdftops filters by hand with PPD=ps.ppd gives the same result. *DefaultOutputOrder: Reverse instead of the output bin behaves the same way.

Expected behavior

An explicit outputorder=reverse prints the pages in reverse order and outputorder=normal in normal order, as on queues without a reverse default. The PPD's default order should only apply when the job doesn't ask for one.

Screenshots

No screenshots; the relevant log line from cupsfilter with outputorder=reverse shows pstops reversing the already reversed pages:

DEBUG: ppdFilterPSToPS: slow_collate=0, slow_duplex=0, slow_order=1

System Information:

  • OS: Arch Linux
  • Version: libppd 2.1.1 (libppd master 93ed8499 has the same code)
  • Version of CUPS, libcupsfilters, ...: CUPS 2.4.20, cups-filters 2.0.1, libcupsfilters 2.2.1 (git 3bf18925) and master 89e4c33a with OpenPrinting/libcupsfilters#366

Additional context

When pdftopdf has run, ppdFilterPDFToPS() drops OutputOrder from the pstops options (pdftops.c L77–L91, L595). pstops then treats the missing option as "use the PPD default" (imagetops-pstops.c L4257–L4275) and reverses again (L4385).

Suggested fix: pass OutputOrder=Normal to pstops instead of dropping it, as Collate=True is added back (L609–L617). This needs coordinating with OpenPrinting/libcupsfilters#366, which leaves the default order of PostScript PPD queues to pstops because of this bug. A pdftopdf marker like %%PDFTOPDFNumCopies could tell libppd when pdftopdf has applied the order, so mixed versions keep working. Happy to help with either side.

Tested with the generic PPD above, not on a physical face-up PostScript printer.

主要言語
C
スター
6
フォーク
38
平均マージ
16時間 30分
マージ済み PR(30日)
25

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

OpenPrinting/libppd のほかの issue

OpenPrinting/libppd の issue をすべて見る

似ている issue

C の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。