Follow-ups left open by the station-series cleanup (#466)
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 35/100
- Issue-Typ
- Bug
- Klarheit
- Größtenteils klar
- Aktivitätsstatus
- Aktiv
- Bereich
- embedded-iot, testing
Rechercherichtung
Start by reading docs/mt7612u-tx-retry.md and the station harnesses named in the issue: realtek_station_onair.sh, mt7612u_sta_identity.sh, mt7612u_sta_uplink.sh, and mt7612u_ap_onair.sh; inspect the gate_txs implementation and related harness tests. The issue lists several independent fixes and observations, so confirm which follow-ups remain before changing anything. Done means correcting the actionable harness behaviors and documenting the settling limitation, with tests or hardware runs confirming the results.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Left open by #466 (merged as 1134df9): the station-series review follow-ups, part of the #465 harness sweep, the #461 stale-EXT claim in gate_txs, and the txdemo thread-join guards.
From the review (hardware: realtek_station_onair 5/5 on 8812CU + 8812BU + MT7612U AP; uplink A/B against master)
gate_txsstale-EXT claim can over-attribute. One arm on the review bench read61/60, 1 stale-EXT entries claimed, 11 foreign: the arm then received all 60 of its own entries, so the claimed one was not its own (or a MAC duplicate). Printed, not clipped, butsuccessis inflated by one. Suggested self-correction: track own-pktid entries separately and at arm end, if own == n and stale_ext == 1, move the claimed entry back tolate_prev.- The
stale_settledgate cascades. One UNSETTLED arm disables the claim for every following arm until one settles on its own - a chain of seven consecutive 59/60 arms on the review bench. Correct by the documented rule;docs/mt7612u-tx-retry.mdshould say the claim buys little on a unit whose arms do not settle. - The #461 multi-entry loss is far worse on a second unit. Unicast-to-peer gate arms (b-e) landed 0-11/60 own entries on both passes, ~10 per arm carrying the previous arm's pktid, identical on master. Not this PR; recorded here so #461 has the second data point.
realtek_station_onair.sh:tail_mscan be negative (-6 ms in arm C: the finaltx.statstpreceded the lasttx.reportt). Harmless tolive; clamp at 0 or note it in thesummarizecomment.mt7612u_sta_identity.sh: an overrun BSSID gate setsr_bss=2, but the verdictcasehas only0,3,*, so the operator reads "did not pass" for what the exit code calls INCONCLUSIVE. Add a2)branch.mt7612u_sta_uplink.sh:dut_boundis per harness arm (552 s at FRAMES=60, 1128 s at 200) while the header's 25-minute figure covers both arms; the margin for the slower un-ACKed arm at FRAMES=200 is thin. Size it from the measured figure.mt7612u_ap_onair.sh: on the KILL pathreapdropsKIDSwithoutwaiting the killed children, leaving zombies for the rest of the run.- Firmware readability preflight (#465 class). On a host whose MediaTek firmware is zstd-compressed (
/lib/firmware/mediatek/*.bin.zst),sta_fw_linksucceeds, the probe logscannot open firmware/mt7662_rom_patch.bin, and the uplink harness scoresABORTED the DUT did not confirm retry limit 15:with an empty reason. Checking the two blobs are readable through the link turns a dead rig into a refusal in seconds.
From the PR description
- Find the uplink harness's multi-entry status loss (#461).
- Unify the INT/TERM exit code across the station harnesses: realtek_station_onair, mt7612u_sta_onair and mt7612u_sta_identity exit 3; autoack, uplink and ap_onair still exit 130.
- From #465, not in #466: the generic Realtek DUT take, the reconnect cell and the CCMP soak (separate PR).
Done by the review, no action
- The "last arm that sent" form of the stale-EXT claim is now hardware-run (it coincided with the previous-arm form: no arm had every submit fail). The claim fired correctly on the session's first arm: 60/60 with 1 claimed on #466 against 59/60 UNSETTLED with 1 foreign on master.
- Vorherrschende Sprache
- C
- Sterne
- 56
- Forks
- 29
- Ø Merge
- 3 Std. 43 Min.
- Gemergte PRs (30 T.)
- 75
Entwicklungsumgebung
Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus OpenIPC/devourer
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
Maintainer antworten meist innerhalb von 1 Tag
-
Follow-ups left open by the 8822B fast bandwidth toggle fix (#584)Evtl. vergeben @josephnef hat das heute übernommen. Offenenhancement
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 42/100
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 12/100
OpenIPC/devourer#579 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
enhancement
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 12/100
Maintainer antworten meist innerhalb von 1 Tag
-
enhancement
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 8/100
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in OpenIPC/devourer
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
Maintainer antworten meist innerhalb von 1 Tag
-
Needs-Triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
Maintainer antworten meist innerhalb von 2 Tagen
-
issue: bug report
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
Maintainer antworten meist innerhalb von 2 Tagen
-
cross-platform fix-now
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
Maintainer antworten meist innerhalb von 1 Tag
-
feature:index kind:crash status:confirmed triaged
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 77/100
clice-io/clice#1123 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag