make 3.81 reads a != or ::= assignment as something else and leaves the variable empty, with no error; no local gate sees it

Offen
#2,456 5 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
75/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Bereich
build-system

Rechercherichtung

Start with the Makefile and the existing precheck, then read tools/make381_cases.json and tools/make381_oracle.py to see how the GNU Make 3.81 expectations are derived. Add coverage for assignments in the Makefile and included files, keeping the recipe, $(shell ...), and comment controls clean. Done means make precheck reports file and line for both unsupported assignment forms; document that undefine and private are refused loudly by 3.81.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area:gates kind:gate-defect needs-triage

GNU Make 3.81, the make of the macOS runners, does not know the != and ::= assignments. It does not stop on them either: it reads the line another way and the variable is empty, with exit code 0. Run on a real GNU Make 3.81 built from the GNU source, beside GNU Make 4.3 (cases bang-assign and colon-colon-eq of tools/make381_cases.json, on the branch of #2448):

X != printf 'a'        3.81: X=[]   4.3: X=[a]
X ::= a                3.81: X=[]   4.3: X=[a]

So a Makefile line written with either form passes every Linux gate and silently builds something else on macOS. undefine and the private modifier are refused loudly by 3.81 (missing separator, multiple target patterns), so the macOS jobs would at least fail on them.

The tree's Makefile uses none of the four today (checked by reading the base of #2448). The number-sign check of #2448 names them in its header as not covered.

Done when

  • A check that runs in make precheck fails on a != or ::= assignment in the Makefile or a file it includes, by file and line, and is shown red first on a planted line of each form.
  • Its expectations are cases whose answers come from a real GNU Make 3.81 (tools/make381_oracle.py derives them), including controls that stay clean: != inside a recipe, inside a $(shell ...) argument (the tree has one, in an awk expression), and in a comment.
  • It says what it does with undefine and private (covered, or named as not covered because 3.81 refuses them loudly).

— Claude DevBox

Vorherrschende Sprache
C
Sterne
3
Forks
7
Ø Merge
3 Std. 28 Min.
Gemergte PRs (30 T.)
270

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus InauguralSystems/EigenScript

Alle Issues in InauguralSystems/EigenScript

Ähnliche Issues

Weitere Issues zu C

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.