make 3.81 reads a != or ::= assignment as something else and leaves the variable empty, with no error; no local gate sees it

Aberta
#2,456 5 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
75/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Domínio
build-system

Direção de pesquisa

Start with the Makefile and the existing precheck, then read tools/make381_cases.json and tools/make381_oracle.py to see how the GNU Make 3.81 expectations are derived. Add coverage for assignments in the Makefile and included files, keeping the recipe, $(shell ...), and comment controls clean. Done means make precheck reports file and line for both unsupported assignment forms; document that undefine and private are refused loudly by 3.81.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

area:gates kind:gate-defect needs-triage

GNU Make 3.81, the make of the macOS runners, does not know the != and ::= assignments. It does not stop on them either: it reads the line another way and the variable is empty, with exit code 0. Run on a real GNU Make 3.81 built from the GNU source, beside GNU Make 4.3 (cases bang-assign and colon-colon-eq of tools/make381_cases.json, on the branch of #2448):

X != printf 'a'        3.81: X=[]   4.3: X=[a]
X ::= a                3.81: X=[]   4.3: X=[a]

So a Makefile line written with either form passes every Linux gate and silently builds something else on macOS. undefine and the private modifier are refused loudly by 3.81 (missing separator, multiple target patterns), so the macOS jobs would at least fail on them.

The tree's Makefile uses none of the four today (checked by reading the base of #2448). The number-sign check of #2448 names them in its header as not covered.

Done when

  • A check that runs in make precheck fails on a != or ::= assignment in the Makefile or a file it includes, by file and line, and is shown red first on a planted line of each form.
  • Its expectations are cases whose answers come from a real GNU Make 3.81 (tools/make381_oracle.py derives them), including controls that stay clean: != inside a recipe, inside a $(shell ...) argument (the tree has one, in an awk expression), and in a comment.
  • It says what it does with undefine and private (covered, or named as not covered because 3.81 refuses them loudly).

— Claude DevBox

Linguagem predominante
C
Estrelas
3
Forks
7
Merge médio
3h 28min
PRs com merge (30d)
270

Preparar o ambiente

Abrir no Codespaces

Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de InauguralSystems/EigenScript

Todas as issues de InauguralSystems/EigenScript

Issues semelhantes

Mais issues de C

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.