make 3.81 reads a != or ::= assignment as something else and leaves the variable empty, with no error; no local gate sees it

オープン
#2,456 コメント 5 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
75/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
領域
build-system

調査の方向性

Start with the Makefile and the existing precheck, then read tools/make381_cases.json and tools/make381_oracle.py to see how the GNU Make 3.81 expectations are derived. Add coverage for assignments in the Makefile and included files, keeping the recipe, $(shell ...), and comment controls clean. Done means make precheck reports file and line for both unsupported assignment forms; document that undefine and private are refused loudly by 3.81.

索引モデルが issue の本文から書いたものです。

説明

area:gates kind:gate-defect needs-triage

GNU Make 3.81, the make of the macOS runners, does not know the != and ::= assignments. It does not stop on them either: it reads the line another way and the variable is empty, with exit code 0. Run on a real GNU Make 3.81 built from the GNU source, beside GNU Make 4.3 (cases bang-assign and colon-colon-eq of tools/make381_cases.json, on the branch of #2448):

X != printf 'a'        3.81: X=[]   4.3: X=[a]
X ::= a                3.81: X=[]   4.3: X=[a]

So a Makefile line written with either form passes every Linux gate and silently builds something else on macOS. undefine and the private modifier are refused loudly by 3.81 (missing separator, multiple target patterns), so the macOS jobs would at least fail on them.

The tree's Makefile uses none of the four today (checked by reading the base of #2448). The number-sign check of #2448 names them in its header as not covered.

Done when

  • A check that runs in make precheck fails on a != or ::= assignment in the Makefile or a file it includes, by file and line, and is shown red first on a planted line of each form.
  • Its expectations are cases whose answers come from a real GNU Make 3.81 (tools/make381_oracle.py derives them), including controls that stay clean: != inside a recipe, inside a $(shell ...) argument (the tree has one, in an awk expression), and in a comment.
  • It says what it does with undefine and private (covered, or named as not covered because 3.81 refuses them loudly).

— Claude DevBox

主要言語
C
スター
3
フォーク
7
平均マージ
3時間 28分
マージ済み PR(30日)
270

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

InauguralSystems/EigenScript のほかの issue

InauguralSystems/EigenScript の issue をすべて見る

似ている issue

C の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。