strict_differential cannot run on a ThreadSanitizer build: its address-space cap stops the sanitizer, so [99s] is left out of the tsan-http lane

Offen
#2,425 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
56/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
c, github-actions
Bereich
ci-cd, testing

Rechercherichtung

Start with tools/strict_differential.sh and its address-space policy self-test; compare the existing ASan and ordinary cases, then inspect the tsan-http lane step and its exclusion comment. Run make tsan-http and tools/strict_differential.sh --no-baseline on a ThreadSanitizer build. Done means the script reaches a verdict, [99s] is included in the lane, and its log reports OK: [99s] ran.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area:gates found-by:ci kind:gate-defect status:held

tools/strict_differential.sh (suite section [99s]) cannot run on a ThreadSanitizer build. Found by putting [99s] into the tsan-http lane for #2367, on a hosted runner (make tsan-http, the lane's own step, setarch -R):

[99s] Strict argument-guard differential (#971, no-baseline half)
GFX address-space policy: platform=Linux subject=ordinary baseline=none (ordinary Linux=1500000 KiB; ordinary Darwin=inherited limits, no imposed address-space cap; ASan=inherited unlimited)
  CAPABILITY DID NOT MEASURE: gfx — invalid: 66 ==10722==WARNING: Program is run with limited virtual address space, which wouldn't work with ThreadSanitizer.
  ABORTED: this differential exited (rc=1) before printing a verdict.
  FAIL: strict_differential.sh exited 1 without completing — section verdict is not trustworthy (#988)

The tool's address-space policy knows two kinds of subject: an ASan build, which keeps the limits it inherits, and an "ordinary" one, which gets a cap of 1,500,000 KiB on Linux. A ThreadSanitizer build is classed as ordinary, gets the cap, and ThreadSanitizer refuses to start under one (exit 66).

Why it matters

Three rows of the differential start an HTTP server (tests/strict_shape_cases.json, the rows with http_context, through tests/test_http_server.sh --strict-shape). #2367 asks that every section that starts an HTTP server run under ThreadSanitizer or be named as left out with its reason. [99s] is named as left out, with this as the reason; those three servers have no race coverage until the section can run there.

Done when

  • On a make tsan-http build, tools/strict_differential.sh --no-baseline runs to a verdict: the policy classes a ThreadSanitizer subject as one that keeps the limits it inherits, as it does an ASan one, and the tool's self-test has a case for it beside the ASan and ordinary cases.
  • [99s] is added to the list of the tsan-http lane's step and the comment that names it as left out is removed, in the same change; the hosted job's log shows OK: [99s] ran.

— Claude DevBox

Vorherrschende Sprache
C
Sterne
3
Forks
7
Ø Merge
3 Std. 28 Min.
Gemergte PRs (30 T.)
270

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus InauguralSystems/EigenScript

Alle Issues in InauguralSystems/EigenScript

Ähnliche Issues

Weitere Issues zu C

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.