strict_differential cannot run on a ThreadSanitizer build: its address-space cap stops the sanitizer, so [99s] is left out of the tsan-http lane

未關閉
#2,425 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
1-2 天
新手友好度
56/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
c, github-actions
領域
ci-cd, testing

研究方向

Start with tools/strict_differential.sh and its address-space policy self-test; compare the existing ASan and ordinary cases, then inspect the tsan-http lane step and its exclusion comment. Run make tsan-http and tools/strict_differential.sh --no-baseline on a ThreadSanitizer build. Done means the script reaches a verdict, [99s] is included in the lane, and its log reports OK: [99s] ran.

由索引模型根據 Issue 內容生成。

描述

area:gates found-by:ci kind:gate-defect status:held

tools/strict_differential.sh (suite section [99s]) cannot run on a ThreadSanitizer build. Found by putting [99s] into the tsan-http lane for #2367, on a hosted runner (make tsan-http, the lane's own step, setarch -R):

[99s] Strict argument-guard differential (#971, no-baseline half)
GFX address-space policy: platform=Linux subject=ordinary baseline=none (ordinary Linux=1500000 KiB; ordinary Darwin=inherited limits, no imposed address-space cap; ASan=inherited unlimited)
  CAPABILITY DID NOT MEASURE: gfx — invalid: 66 ==10722==WARNING: Program is run with limited virtual address space, which wouldn't work with ThreadSanitizer.
  ABORTED: this differential exited (rc=1) before printing a verdict.
  FAIL: strict_differential.sh exited 1 without completing — section verdict is not trustworthy (#988)

The tool's address-space policy knows two kinds of subject: an ASan build, which keeps the limits it inherits, and an "ordinary" one, which gets a cap of 1,500,000 KiB on Linux. A ThreadSanitizer build is classed as ordinary, gets the cap, and ThreadSanitizer refuses to start under one (exit 66).

Why it matters

Three rows of the differential start an HTTP server (tests/strict_shape_cases.json, the rows with http_context, through tests/test_http_server.sh --strict-shape). #2367 asks that every section that starts an HTTP server run under ThreadSanitizer or be named as left out with its reason. [99s] is named as left out, with this as the reason; those three servers have no race coverage until the section can run there.

Done when

  • On a make tsan-http build, tools/strict_differential.sh --no-baseline runs to a verdict: the policy classes a ThreadSanitizer subject as one that keeps the limits it inherits, as it does an ASan one, and the tool's self-test has a case for it beside the ASan and ordinary cases.
  • [99s] is added to the list of the tsan-http lane's step and the comment that names it as left out is removed, in the same change; the hosted job's log shows OK: [99s] ran.

— Claude DevBox

主要語言
C
星號
3
分支
7
平均合併
3 小時 28 分鐘
30 天內合併 PR
270

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

InauguralSystems/EigenScript 的其他 Issue

查看 InauguralSystems/EigenScript 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。