strict_differential cannot run on a ThreadSanitizer build: its address-space cap stops the sanitizer, so [99s] is left out of the tsan-http lane

未关闭
#2,425 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
56/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
c, github-actions
领域
ci-cd, testing

调研方向

Start with tools/strict_differential.sh and its address-space policy self-test; compare the existing ASan and ordinary cases, then inspect the tsan-http lane step and its exclusion comment. Run make tsan-http and tools/strict_differential.sh --no-baseline on a ThreadSanitizer build. Done means the script reaches a verdict, [99s] is included in the lane, and its log reports OK: [99s] ran.

由索引模型根据 Issue 内容生成。

描述

area:gates found-by:ci kind:gate-defect status:held

tools/strict_differential.sh (suite section [99s]) cannot run on a ThreadSanitizer build. Found by putting [99s] into the tsan-http lane for #2367, on a hosted runner (make tsan-http, the lane's own step, setarch -R):

[99s] Strict argument-guard differential (#971, no-baseline half)
GFX address-space policy: platform=Linux subject=ordinary baseline=none (ordinary Linux=1500000 KiB; ordinary Darwin=inherited limits, no imposed address-space cap; ASan=inherited unlimited)
  CAPABILITY DID NOT MEASURE: gfx — invalid: 66 ==10722==WARNING: Program is run with limited virtual address space, which wouldn't work with ThreadSanitizer.
  ABORTED: this differential exited (rc=1) before printing a verdict.
  FAIL: strict_differential.sh exited 1 without completing — section verdict is not trustworthy (#988)

The tool's address-space policy knows two kinds of subject: an ASan build, which keeps the limits it inherits, and an "ordinary" one, which gets a cap of 1,500,000 KiB on Linux. A ThreadSanitizer build is classed as ordinary, gets the cap, and ThreadSanitizer refuses to start under one (exit 66).

Why it matters

Three rows of the differential start an HTTP server (tests/strict_shape_cases.json, the rows with http_context, through tests/test_http_server.sh --strict-shape). #2367 asks that every section that starts an HTTP server run under ThreadSanitizer or be named as left out with its reason. [99s] is named as left out, with this as the reason; those three servers have no race coverage until the section can run there.

Done when

  • On a make tsan-http build, tools/strict_differential.sh --no-baseline runs to a verdict: the policy classes a ThreadSanitizer subject as one that keeps the limits it inherits, as it does an ASan one, and the tool's self-test has a case for it beside the ASan and ordinary cases.
  • [99s] is added to the list of the tsan-http lane's step and the comment that names it as left out is removed, in the same change; the hosted job's log shows OK: [99s] ran.

— Claude DevBox

主要语言
C
星标
3
派生
7
平均合并
3 小时 28 分钟
30 天内合并 PR
270

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

InauguralSystems/EigenScript 的其他 Issue

查看 InauguralSystems/EigenScript 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。