http_early_bind: requests answered before http_serve are not read through the parser, and the documents say every request is

Offen
#2,419 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
52/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
c
Bereich
backend, testing

Rechercherichtung

Start with the “How a request is read” section and the http_early_bind row in docs/BUILTINS.md, then compare the HTTP reader used before http_serve with the parser used afterward. Add a test that sends all four listed requests in both windows and checks the expected responses. Update the documentation and the #2370 changelog wording to match the chosen behavior.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area:http found-by:critic kind:bug

Found by a blind review of a sentence that quoted docs/BUILTINS.md. Run on phase2-numbers at fc63b99d, a build with the HTTP extension.

What happens

docs/BUILTINS.md ("How a request is read (#2370)") says: "The server reads every request through llhttp [...] and serves a request only when the parser has found it complete." Between http_early_bind and http_serve that is not so. The requests of that window are answered by another reader:

http_early_bind of [PORT, "/livez"]
usleep of 5000000
http_route of ["GET", "/livez", "route"]
http_serve of PORT
bytes sent in the window after http_serve
GET /livez HTTP/1.1\r\nHost: x\r\n\r\n 200, body OK 200, body route
GET /livez HTTP/1.1\r\n, the connection held open 200, body OK, at once 408
GET /livez HTTP/1.1\r\nbogus\r\n\r\n (a header line with no colon) 200, body OK 400, Invalid header token
GET /livez HTTP/1.1\nHost: x\n\n (bare LF line ends) 503, Server initializing 400, Expected CRLF after version

So in the window a request line alone is answered before its head has ended, and a head that the parser refuses is answered 200.

Why it matters

No route runs in the window: the answers are the fixed liveness OK and the 503. But the change for #2370 states that request framing no longer disagrees with a conforming proxy, and in this window it can: a proxy in front that waits for the end of a head, or refuses a line with no colon, has read something else than the server answered. And the document's sentence is false as written, for every program that calls http_early_bind.

Done when

  • One of the two: the requests of the window are read through the same parser (the four rows above answer in the window as the parser decides: nothing or 408 for the open request line, 400 for the other two refused heads, and the liveness 200 or the 503 only for a request the parser has found complete); or docs/BUILTINS.md says, in "How a request is read" and in the row of http_early_bind, that the window before http_serve has a reader of its own, what that reader accepts, and that "every request" begins at http_serve. The changelog's sentence for #2370 about a conforming proxy is brought in line with whichever is chosen.
  • A test sends the four requests inside the window and again after http_serve, and pins both columns.

— Claude DevBox

Vorherrschende Sprache
C
Sterne
3
Forks
7
Ø Merge
3 Std. 28 Min.
Gemergte PRs (30 T.)
270

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus InauguralSystems/EigenScript

Alle Issues in InauguralSystems/EigenScript

Ähnliche Issues

Weitere Issues zu C

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.