http_early_bind: requests answered before http_serve are not read through the parser, and the documents say every request is
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 52/100
Línea de trabajo
Start with the “How a request is read” section and the http_early_bind row in docs/BUILTINS.md, then compare the HTTP reader used before http_serve with the parser used afterward. Add a test that sends all four listed requests in both windows and checks the expected responses. Update the documentation and the #2370 changelog wording to match the chosen behavior.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Found by a blind review of a sentence that quoted docs/BUILTINS.md. Run on phase2-numbers at fc63b99d, a build with the HTTP extension.
What happens
docs/BUILTINS.md ("How a request is read (#2370)") says: "The server reads every request through llhttp [...] and serves a request only when the parser has found it complete." Between http_early_bind and http_serve that is not so. The requests of that window are answered by another reader:
http_early_bind of [PORT, "/livez"]
usleep of 5000000
http_route of ["GET", "/livez", "route"]
http_serve of PORT
| bytes sent | in the window | after http_serve |
|---|---|---|
GET /livez HTTP/1.1\r\nHost: x\r\n\r\n |
200, body OK |
200, body route |
GET /livez HTTP/1.1\r\n, the connection held open |
200, body OK, at once |
408 |
GET /livez HTTP/1.1\r\nbogus\r\n\r\n (a header line with no colon) |
200, body OK |
400, Invalid header token |
GET /livez HTTP/1.1\nHost: x\n\n (bare LF line ends) |
503, Server initializing |
400, Expected CRLF after version |
So in the window a request line alone is answered before its head has ended, and a head that the parser refuses is answered 200.
Why it matters
No route runs in the window: the answers are the fixed liveness OK and the 503. But the change for #2370 states that request framing no longer disagrees with a conforming proxy, and in this window it can: a proxy in front that waits for the end of a head, or refuses a line with no colon, has read something else than the server answered. And the document's sentence is false as written, for every program that calls http_early_bind.
Done when
- One of the two: the requests of the window are read through the same parser (the four rows above answer in the window as the parser decides: nothing or
408for the open request line,400for the other two refused heads, and the liveness200or the503only for a request the parser has found complete); ordocs/BUILTINS.mdsays, in "How a request is read" and in the row ofhttp_early_bind, that the window beforehttp_servehas a reader of its own, what that reader accepts, and that "every request" begins athttp_serve. The changelog's sentence for #2370 about a conforming proxy is brought in line with whichever is chosen. - A test sends the four requests inside the window and again after
http_serve, and pins both columns.
— Claude DevBox
- Lenguaje dominante
- C
- Estrellas
- 3
- Forks
- 7
- Merge medio
- 3 h 28 min
- PR fusionados (30 d)
- 270
Preparar el entorno
Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.
- Incluye un Dockerfile o un archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de InauguralSystems/EigenScript
-
area:gates kind:gate-defect
Dificultad 2/5 1-3 horas Aptitud para principiantes 83/100
InauguralSystems/EigenScript#2476 ·
Los mantenedores suelen responder en 1 día
-
area:gates needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
InauguralSystems/EigenScript#2462 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
The hosted-RNG check refuses a clean tree that has a tracked file with a double quote in its nameAbiertoarea:gates kind:gate-defect needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
InauguralSystems/EigenScript#2461 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
area:gates kind:gate-defect needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 86/100
InauguralSystems/EigenScript#2458 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
`http_post`: `headers` text with something after its JSON value now means no headers, without a wordAbiertoarea:http kind:silent-wrong
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
InauguralSystems/EigenScript#2394 · 1 comentario ·
Los mantenedores suelen responder en 1 día
Todos los issues de InauguralSystems/EigenScript
Issues similares
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 92/100
flipperdevices/flipperzero-firmware#4520 ·
Los mantenedores suelen responder en 1 día
-
area/build-framework kind/enhancement priority/low
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
yugabyte/yugabyte-db#38826 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
meshcore-dev/MeshCore#3891 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
bug grammar sev-3
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
-
BUG/MEDIUM: regex: worker SIGSEGV when a regex is applied to an empty body on libc-regex buildsAbiertostatus: needs-triage type: bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100