http_early_bind: requests answered before http_serve are not read through the parser, and the documents say every request is
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start with the “How a request is read” section and the http_early_bind row in docs/BUILTINS.md, then compare the HTTP reader used before http_serve with the parser used afterward. Add a test that sends all four listed requests in both windows and checks the expected responses. Update the documentation and the #2370 changelog wording to match the chosen behavior.
由索引模型根据 Issue 内容生成。
描述
Found by a blind review of a sentence that quoted docs/BUILTINS.md. Run on phase2-numbers at fc63b99d, a build with the HTTP extension.
What happens
docs/BUILTINS.md ("How a request is read (#2370)") says: "The server reads every request through llhttp [...] and serves a request only when the parser has found it complete." Between http_early_bind and http_serve that is not so. The requests of that window are answered by another reader:
http_early_bind of [PORT, "/livez"]
usleep of 5000000
http_route of ["GET", "/livez", "route"]
http_serve of PORT
| bytes sent | in the window | after http_serve |
|---|---|---|
GET /livez HTTP/1.1\r\nHost: x\r\n\r\n |
200, body OK |
200, body route |
GET /livez HTTP/1.1\r\n, the connection held open |
200, body OK, at once |
408 |
GET /livez HTTP/1.1\r\nbogus\r\n\r\n (a header line with no colon) |
200, body OK |
400, Invalid header token |
GET /livez HTTP/1.1\nHost: x\n\n (bare LF line ends) |
503, Server initializing |
400, Expected CRLF after version |
So in the window a request line alone is answered before its head has ended, and a head that the parser refuses is answered 200.
Why it matters
No route runs in the window: the answers are the fixed liveness OK and the 503. But the change for #2370 states that request framing no longer disagrees with a conforming proxy, and in this window it can: a proxy in front that waits for the end of a head, or refuses a line with no colon, has read something else than the server answered. And the document's sentence is false as written, for every program that calls http_early_bind.
Done when
- One of the two: the requests of the window are read through the same parser (the four rows above answer in the window as the parser decides: nothing or
408for the open request line,400for the other two refused heads, and the liveness200or the503only for a request the parser has found complete); ordocs/BUILTINS.mdsays, in "How a request is read" and in the row ofhttp_early_bind, that the window beforehttp_servehas a reader of its own, what that reader accepts, and that "every request" begins athttp_serve. The changelog's sentence for #2370 about a conforming proxy is brought in line with whichever is chosen. - A test sends the four requests inside the window and again after
http_serve, and pins both columns.
— Claude DevBox
- 主要语言
- C
- 星标
- 3
- 派生
- 7
- 平均合并
- 3 小时 28 分钟
- 30 天内合并 PR
- 270
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
InauguralSystems/EigenScript 的其他 Issue
-
area:gates kind:gate-defect
难度 2/5 1-3 小时 新手友好度 83/100
InauguralSystems/EigenScript#2476 ·
维护者通常 1 天内回复
-
area:gates needs-triage
难度 2/5 1-3 小时 新手友好度 78/100
InauguralSystems/EigenScript#2462 · 1 条评论 ·
维护者通常 1 天内回复
-
The hosted-RNG check refuses a clean tree that has a tracked file with a double quote in its name未关闭area:gates kind:gate-defect needs-triage
难度 2/5 1-3 小时 新手友好度 78/100
InauguralSystems/EigenScript#2461 · 1 条评论 ·
维护者通常 1 天内回复
-
area:gates kind:gate-defect needs-triage
难度 2/5 1-3 小时 新手友好度 86/100
InauguralSystems/EigenScript#2458 · 1 条评论 ·
维护者通常 1 天内回复
-
`http_post`: `headers` text with something after its JSON value now means no headers, without a word未关闭area:http kind:silent-wrong
难度 2/5 1-3 小时 新手友好度 72/100
InauguralSystems/EigenScript#2394 · 1 条评论 ·
维护者通常 1 天内回复
查看 InauguralSystems/EigenScript 的全部 Issue
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 92/100
flipperdevices/flipperzero-firmware#4520 ·
维护者通常 1 天内回复
-
area/build-framework kind/enhancement priority/low
难度 2/5 1-3 小时 新手友好度 77/100
yugabyte/yugabyte-db#38826 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 88/100
meshcore-dev/MeshCore#3891 · 1 条评论 ·
维护者通常 1 天内回复
-
bug grammar sev-3
难度 2/5 1-3 小时 新手友好度 76/100
-
status: needs-triage type: bug
难度 2/5 1-3 小时 新手友好度 75/100