http: the leak check added with #2370 (RSS5) swings by up to 3.9 MB between clean batches; its false-red margin is about 2.4 MB

Offen
#2,414 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
57/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
c
Bereich
performance, testing

Rechercherichtung

Start with tests/test_http_rss_growth.sh and the RSS5 check added by #2370, then run it against a clean make http build. Record the median and spread of the three batch growths over 20 runs on both the dev box and hosted runner image. If the stated stability criterion fails, change the measurement method and confirm the planted leak still triggers a failure.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area:http kind:flake

Seen by the builder of #2370's fix round, on the branch of that change (the check does not exist on main until it lands).

The check that #2370 adds to tests/test_http_rss_growth.sh (RSS5) measures the server's resident size after a warm-up and after each of three batches of 2,000 requests, and fails when the median growth of a batch is over 4,096 kB. With the batch the amended bar gives (500 chunked bodies of 60,000 bytes in each batch, each in a room of 65,536 bytes), the three growths of a clean make http build were, in four runs:

  • [356, -1752, 44], median 44 kB
  • [3888, -1644, 1644], median 1,644 kB
  • [-1752, 1752, 0], median 0 kB
  • [-1796, 1820, -1820], median -1,796 kB

One batch moves by about what the allocator trims and grows back (1.6 to 3.9 MB). The median absorbs one such batch; two in the same direction would pass the threshold with no leak. The planted leak (a request's body never freed) grows 26,540 to 37,028 kB a batch, so the check sees the fault it is for by a wide margin; the narrow side is the false red.

Done when

  • RSS5's median and the spread of its three batches are recorded over 20 runs on the make http build, on the dev box and on the hosted runner image.
  • Either the largest batch growth of a clean run stays under half the threshold in all of them, or the check's method is changed (a larger batch count, a trim before each sample, or the heap leg once #2364 gives it a reading) and the planted leak is shown red under the new method.

— Claude DevBox

Vorherrschende Sprache
C
Sterne
3
Forks
7
Ø Merge
3 Std. 28 Min.
Gemergte PRs (30 T.)
270

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus InauguralSystems/EigenScript

Alle Issues in InauguralSystems/EigenScript

Ähnliche Issues

Weitere Issues zu C

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.