http: the leak check added with #2370 (RSS5) swings by up to 3.9 MB between clean batches; its false-red margin is about 2.4 MB

Abierto
#2,414 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
57/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
c

Línea de trabajo

Start with tests/test_http_rss_growth.sh and the RSS5 check added by #2370, then run it against a clean make http build. Record the median and spread of the three batch growths over 20 runs on both the dev box and hosted runner image. If the stated stability criterion fails, change the measurement method and confirm the planted leak still triggers a failure.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:http kind:flake

Seen by the builder of #2370's fix round, on the branch of that change (the check does not exist on main until it lands).

The check that #2370 adds to tests/test_http_rss_growth.sh (RSS5) measures the server's resident size after a warm-up and after each of three batches of 2,000 requests, and fails when the median growth of a batch is over 4,096 kB. With the batch the amended bar gives (500 chunked bodies of 60,000 bytes in each batch, each in a room of 65,536 bytes), the three growths of a clean make http build were, in four runs:

  • [356, -1752, 44], median 44 kB
  • [3888, -1644, 1644], median 1,644 kB
  • [-1752, 1752, 0], median 0 kB
  • [-1796, 1820, -1820], median -1,796 kB

One batch moves by about what the allocator trims and grows back (1.6 to 3.9 MB). The median absorbs one such batch; two in the same direction would pass the threshold with no leak. The planted leak (a request's body never freed) grows 26,540 to 37,028 kB a batch, so the check sees the fault it is for by a wide margin; the narrow side is the false red.

Done when

  • RSS5's median and the spread of its three batches are recorded over 20 runs on the make http build, on the dev box and on the hosted runner image.
  • Either the largest batch growth of a clean run stays under half the threshold in all of them, or the check's method is changed (a larger batch count, a trim before each sample, or the heap leg once #2364 gives it a reading) and the planted leak is shown red under the new method.

— Claude DevBox

Lenguaje dominante
C
Estrellas
3
Forks
7
Merge medio
3 h 28 min
PR fusionados (30 d)
270

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de InauguralSystems/EigenScript

Todos los issues de InauguralSystems/EigenScript

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.