http: the leak check added with #2370 (RSS5) swings by up to 3.9 MB between clean batches; its false-red margin is about 2.4 MB

未关闭
#2,414 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
57/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
c

调研方向

Start with tests/test_http_rss_growth.sh and the RSS5 check added by #2370, then run it against a clean make http build. Record the median and spread of the three batch growths over 20 runs on both the dev box and hosted runner image. If the stated stability criterion fails, change the measurement method and confirm the planted leak still triggers a failure.

由索引模型根据 Issue 内容生成。

描述

area:http kind:flake

Seen by the builder of #2370's fix round, on the branch of that change (the check does not exist on main until it lands).

The check that #2370 adds to tests/test_http_rss_growth.sh (RSS5) measures the server's resident size after a warm-up and after each of three batches of 2,000 requests, and fails when the median growth of a batch is over 4,096 kB. With the batch the amended bar gives (500 chunked bodies of 60,000 bytes in each batch, each in a room of 65,536 bytes), the three growths of a clean make http build were, in four runs:

  • [356, -1752, 44], median 44 kB
  • [3888, -1644, 1644], median 1,644 kB
  • [-1752, 1752, 0], median 0 kB
  • [-1796, 1820, -1820], median -1,796 kB

One batch moves by about what the allocator trims and grows back (1.6 to 3.9 MB). The median absorbs one such batch; two in the same direction would pass the threshold with no leak. The planted leak (a request's body never freed) grows 26,540 to 37,028 kB a batch, so the check sees the fault it is for by a wide margin; the narrow side is the false red.

Done when

  • RSS5's median and the spread of its three batches are recorded over 20 runs on the make http build, on the dev box and on the hosted runner image.
  • Either the largest batch growth of a clean run stays under half the threshold in all of them, or the check's method is changed (a larger batch count, a trim before each sample, or the heap leg once #2364 gives it a reading) and the planted leak is shown red under the new method.

— Claude DevBox

主要语言
C
星标
3
派生
7
平均合并
3 小时 28 分钟
30 天内合并 PR
270

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

InauguralSystems/EigenScript 的其他 Issue

查看 InauguralSystems/EigenScript 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。