observe: a path that isn't a git checkout is reported as 'worktree CHANGED - report this' (console, job summary, Action PR comment)
Maintainer antworten meist innerhalb von 1 Tag
Bewertung
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Anfängerfreundlichkeit
- 35/100
- Issue-Typ
- Bug
- Klarheit
- Klar beschrieben
- Aktivitätsstatus
- Veraltet
- Tech-Stack
- github-actions, node.js, typescript
- Bereich
- ci-cd, testing-qa
Rechercherichtung
Start with the three warning displays named in the issue: packages/diffci-cli/src/client/cli.ts, packages/diffci-cli/src/client/job-summary.ts, and action/impact.mjs; then read observe() in packages/diffci-cli/src/client/observe.ts to understand the evidence fields. Check how each display distinguishes an actual difference from missing evidence, and run the relevant tests for those outputs. Done means missing evidence produces no changed-worktree warning, while real differences and disappearing evidence still do.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
What went wrong?
If the observed path is not a git checkout, the observation refuses, which is correct. But the console line, the job summary and the Action's pull request comment all say the working tree changed while DiffCI observed it, and ask the user to file a DiffCI bug. DiffCI changed nothing. There was simply no checkout to compare before and after.
This is easy to hit with the Action. Any job that checks out into a subdirectory (actions/checkout with path:, as examples/github-actions-check-plan.yml does) and keeps the default repository-path: ${{ github.workspace }} gets the false alarm.
DiffCI version
CLI 0.3.54 (the Action's pinned default); core main 40aa308
Repro
mkdir -p ws/target && cd ws/target && git init -q && git commit -q --allow-empty -m a && git commit -q --allow-empty -m b && cd ..
echo '{"pull_request":{"number":1,"base":{"sha":"x"},"head":{"sha":"y"}}}' > ../event.json
GITHUB_ACTIONS=true GITHUB_EVENT_NAME=pull_request GITHUB_EVENT_PATH=$PWD/../event.json GITHUB_STEP_SUMMARY=$PWD/../summary.md \
npx -y -p @diffci.com/[email protected] diffci observe --repo "$PWD" --no-send --out /tmp/r.json
Actual
status: REFUSED
non-interference: worktree CHANGED - report this, report written outside the checkout
The job summary has the same message:
> [!WARNING]
> The working tree changed while DiffCI observed it. Please report this at https://github.com/DiffCI/core/issues.
action/impact.mjs's formatComment puts the same warning in the PR comment when comment: "true". The report itself is accurate: nonInterference is {"worktreeUnchanged": false} with no headSha* or worktreeDigest* evidence at all.
Cause
observe() sets worktreeUnchanged to false whenever it cannot read HEAD or the tree (packages/diffci-cli/src/client/observe.ts:183-187). That is the right value for "not proven unchanged". But all three places that display it read false as "changed":
packages/diffci-cli/src/client/cli.ts:899packages/diffci-cli/src/client/job-summary.ts:73action/impact.mjs:115
Expected
When nothing could be read before or after (none of the four evidence fields is present), DiffCI has nothing to compare and makes no claim. The refusal reason is enough, and there is no "report this" warning. A real before/after difference, or evidence that disappears, still raises the warning. Narrowing does not change: a refused or unproven observation still never narrows.
- Vorherrschende Sprache
- TypeScript
- Sterne
- 0
- Forks
- 4
- Ø Merge
- 18 Std. 41 Min.
- Gemergte PRs (30 T.)
- 48
Entwicklungsumgebung
Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.
- Kein Dockerfile und keine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus DiffCI/core
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
Maintainer antworten meist innerhalb von 1 Tag
-
Planner: splitParts regex is quadratic on a quote followed by many backticks, so the fuzz test fails at randomEvtl. vergeben @FredApps hat das heute übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 86/100
Maintainer antworten meist innerhalb von 1 Tag
-
Agent tools: changed_files lists only the new path of a renamed fileEvtl. vergeben @FredApps hat das heute übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 88/100
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 84/100
DiffCI/core#243 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
adapter good first issue
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 88/100
Maintainer antworten meist innerhalb von 1 Tag
Ähnliche Issues
-
agent-ready area: ui-server priority: p3 type: test
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
schlessera/brain-kit#4249 ·
Maintainer antworten meist innerhalb von 1 Tag
-
documentation tool triaged
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 73/100
can1357/oh-my-pi#19608 · 2 Kommentare ·
Maintainer antworten meist innerhalb von 1 Tag
-
dependencies tech-debt
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 65/100
bcgov/nr-waste-plus#1549 ·
Maintainer antworten meist innerhalb von 1 Tag
-
enhancement good first issue
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
blixvip/solana-token-meta#17 ·
-
enhancement good first issue
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
blixvip/solana-tx-parse#18 ·