observe: a path that isn't a git checkout is reported as 'worktree CHANGED - report this' (console, job summary, Action PR comment)
維護者通常 1 天內回覆
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 35/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 停滯
- 技術堆疊
- github-actions, node.js, typescript
- 領域
- ci-cd, testing-qa
研究方向
Start with the three warning displays named in the issue: packages/diffci-cli/src/client/cli.ts, packages/diffci-cli/src/client/job-summary.ts, and action/impact.mjs; then read observe() in packages/diffci-cli/src/client/observe.ts to understand the evidence fields. Check how each display distinguishes an actual difference from missing evidence, and run the relevant tests for those outputs. Done means missing evidence produces no changed-worktree warning, while real differences and disappearing evidence still do.
由索引模型根據 Issue 內容生成。
描述
What went wrong?
If the observed path is not a git checkout, the observation refuses, which is correct. But the console line, the job summary and the Action's pull request comment all say the working tree changed while DiffCI observed it, and ask the user to file a DiffCI bug. DiffCI changed nothing. There was simply no checkout to compare before and after.
This is easy to hit with the Action. Any job that checks out into a subdirectory (actions/checkout with path:, as examples/github-actions-check-plan.yml does) and keeps the default repository-path: ${{ github.workspace }} gets the false alarm.
DiffCI version
CLI 0.3.54 (the Action's pinned default); core main 40aa308
Repro
mkdir -p ws/target && cd ws/target && git init -q && git commit -q --allow-empty -m a && git commit -q --allow-empty -m b && cd ..
echo '{"pull_request":{"number":1,"base":{"sha":"x"},"head":{"sha":"y"}}}' > ../event.json
GITHUB_ACTIONS=true GITHUB_EVENT_NAME=pull_request GITHUB_EVENT_PATH=$PWD/../event.json GITHUB_STEP_SUMMARY=$PWD/../summary.md \
npx -y -p @diffci.com/[email protected] diffci observe --repo "$PWD" --no-send --out /tmp/r.json
Actual
status: REFUSED
non-interference: worktree CHANGED - report this, report written outside the checkout
The job summary has the same message:
> [!WARNING]
> The working tree changed while DiffCI observed it. Please report this at https://github.com/DiffCI/core/issues.
action/impact.mjs's formatComment puts the same warning in the PR comment when comment: "true". The report itself is accurate: nonInterference is {"worktreeUnchanged": false} with no headSha* or worktreeDigest* evidence at all.
Cause
observe() sets worktreeUnchanged to false whenever it cannot read HEAD or the tree (packages/diffci-cli/src/client/observe.ts:183-187). That is the right value for "not proven unchanged". But all three places that display it read false as "changed":
packages/diffci-cli/src/client/cli.ts:899packages/diffci-cli/src/client/job-summary.ts:73action/impact.mjs:115
Expected
When nothing could be read before or after (none of the four evidence fields is present), DiffCI has nothing to compare and makes no claim. The refusal reason is enough, and there is no "report this" warning. A real before/after difference, or evidence that disappears, still raises the warning. Narrowing does not change: a refused or unproven observation still never narrows.
- 主要語言
- TypeScript
- 星號
- 0
- 分支
- 4
- 平均合併
- 18 小時 41 分鐘
- 30 天內合併 PR
- 48
環境準備
在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
DiffCI/core 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆
-
Planner: splitParts regex is quadratic on a quote followed by many backticks, so the fuzz test fails at random可能已有人在做 @FredApps 今天認領。 未關閉
難度 2/5 1-3 小時 新手友好度 86/100
維護者通常 1 天內回覆
-
Agent tools: changed_files lists only the new path of a renamed file可能已有人在做 @FredApps 今天認領。 未關閉
難度 2/5 1-3 小時 新手友好度 88/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 84/100
維護者通常 1 天內回覆
-
adapter good first issue
難度 2/5 1-3 小時 新手友好度 88/100
維護者通常 1 天內回覆
相似的 Issue
-
agent-ready area: ui-server priority: p3 type: test
難度 2/5 1-3 小時 新手友好度 78/100
schlessera/brain-kit#4249 ·
維護者通常 1 天內回覆
-
documentation tool triaged
難度 2/5 1-3 小時 新手友好度 73/100
can1357/oh-my-pi#19608 · 2 則留言 ·
維護者通常 1 天內回覆
-
dependencies tech-debt
難度 2/5 1-3 小時 新手友好度 65/100
bcgov/nr-waste-plus#1549 ·
維護者通常 1 天內回覆
-
enhancement good first issue
難度 2/5 1-3 小時 新手友好度 78/100
blixvip/solana-token-meta#17 ·
-
enhancement good first issue
難度 2/5 1-3 小時 新手友好度 78/100
blixvip/solana-tx-parse#18 ·