observe: a path that isn't a git checkout is reported as 'worktree CHANGED - report this' (console, job summary, Action PR comment)
维护者通常 1 天内回复
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 停滞
- 技术栈
- github-actions, node.js, typescript
- 领域
- ci-cd, testing-qa
调研方向
Start with the three warning displays named in the issue: packages/diffci-cli/src/client/cli.ts, packages/diffci-cli/src/client/job-summary.ts, and action/impact.mjs; then read observe() in packages/diffci-cli/src/client/observe.ts to understand the evidence fields. Check how each display distinguishes an actual difference from missing evidence, and run the relevant tests for those outputs. Done means missing evidence produces no changed-worktree warning, while real differences and disappearing evidence still do.
由索引模型根据 Issue 内容生成。
描述
What went wrong?
If the observed path is not a git checkout, the observation refuses, which is correct. But the console line, the job summary and the Action's pull request comment all say the working tree changed while DiffCI observed it, and ask the user to file a DiffCI bug. DiffCI changed nothing. There was simply no checkout to compare before and after.
This is easy to hit with the Action. Any job that checks out into a subdirectory (actions/checkout with path:, as examples/github-actions-check-plan.yml does) and keeps the default repository-path: ${{ github.workspace }} gets the false alarm.
DiffCI version
CLI 0.3.54 (the Action's pinned default); core main 40aa308
Repro
mkdir -p ws/target && cd ws/target && git init -q && git commit -q --allow-empty -m a && git commit -q --allow-empty -m b && cd ..
echo '{"pull_request":{"number":1,"base":{"sha":"x"},"head":{"sha":"y"}}}' > ../event.json
GITHUB_ACTIONS=true GITHUB_EVENT_NAME=pull_request GITHUB_EVENT_PATH=$PWD/../event.json GITHUB_STEP_SUMMARY=$PWD/../summary.md \
npx -y -p @diffci.com/[email protected] diffci observe --repo "$PWD" --no-send --out /tmp/r.json
Actual
status: REFUSED
non-interference: worktree CHANGED - report this, report written outside the checkout
The job summary has the same message:
> [!WARNING]
> The working tree changed while DiffCI observed it. Please report this at https://github.com/DiffCI/core/issues.
action/impact.mjs's formatComment puts the same warning in the PR comment when comment: "true". The report itself is accurate: nonInterference is {"worktreeUnchanged": false} with no headSha* or worktreeDigest* evidence at all.
Cause
observe() sets worktreeUnchanged to false whenever it cannot read HEAD or the tree (packages/diffci-cli/src/client/observe.ts:183-187). That is the right value for "not proven unchanged". But all three places that display it read false as "changed":
packages/diffci-cli/src/client/cli.ts:899packages/diffci-cli/src/client/job-summary.ts:73action/impact.mjs:115
Expected
When nothing could be read before or after (none of the four evidence fields is present), DiffCI has nothing to compare and makes no claim. The refusal reason is enough, and there is no "report this" warning. A real before/after difference, or evidence that disappears, still raises the warning. Narrowing does not change: a refused or unproven observation still never narrows.
- 主要语言
- TypeScript
- 星标
- 0
- 派生
- 4
- 平均合并
- 18 小时 41 分钟
- 30 天内合并 PR
- 48
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
DiffCI/core 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
Planner: splitParts regex is quadratic on a quote followed by many backticks, so the fuzz test fails at random可能已有人在做 @FredApps 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 86/100
维护者通常 1 天内回复
-
Agent tools: changed_files lists only the new path of a renamed file可能已有人在做 @FredApps 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 88/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
adapter good first issue
难度 2/5 1-3 小时 新手友好度 88/100
维护者通常 1 天内回复
相似的 Issue
-
agent-ready area: ui-server priority: p3 type: test
难度 2/5 1-3 小时 新手友好度 78/100
schlessera/brain-kit#4249 ·
维护者通常 1 天内回复
-
documentation tool triaged
难度 2/5 1-3 小时 新手友好度 73/100
can1357/oh-my-pi#19608 · 2 条评论 ·
维护者通常 1 天内回复
-
dependencies tech-debt
难度 2/5 1-3 小时 新手友好度 65/100
bcgov/nr-waste-plus#1549 ·
维护者通常 1 天内回复
-
enhancement good first issue
难度 2/5 1-3 小时 新手友好度 78/100
blixvip/solana-token-meta#17 ·
-
enhancement good first issue
难度 2/5 1-3 小时 新手友好度 78/100
blixvip/solana-tx-parse#18 ·