verify: --redact-paths always widens to the full suite, with a misleading reason

Offen
#275 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@FredApps arbeitet bereits daran.

Seit 17.11.2026.

  • #276 von @FredApps — offen

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
35/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Veraltet
Tech-Stack
node.js, typescript
Bereich
ci-cd, testing

Rechercherichtung

Start with the observe calls in packages/diffci-cli/src/client/verify.ts, then trace how selectedTests, proposedCommands, and executableSelection are handled in observe.ts and verify.ts. Reproduce the reported --changed --no-checks --redact-paths --json case and inspect the tests covering redacted selection. Done means selected verification stays targeted with redacted paths in the receipt, or any widening clearly reports its redaction cause; pull request #276 is already open.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

What went wrong?

diffci verify --redact-paths never runs a selected set of tests. Every redacted run widens to the full suite, and the reason it gives is misleading.

There are two parts:

  1. Every redacted run widens to the full suite. verifyChanged, verifyRange (and verifyScoped, through verifyChangedSnapshot) pass redactPaths to observe (packages/diffci-cli/src/client/verify.ts, the observe({...}) calls in verifyChangedSnapshot and verifyCommitRange). observe then returns selectedTests as sha256-12 digests (observe.ts, selectedTests.map(hashPath)), while proposedCommands still carry the real paths. executableSelection (verify.ts) matches the real command against the digests. unmatchedNodeTests therefore finds that no selected file matches, and the run falls back to the full test command. (For other runners, inferSelectedCommand receives digests in place of paths.)

  2. The reason is misleading. It reads as if the selection could not be expressed as a command:

    selected verification was not executable (node --test would not match 1 selected test file(s), such as 19e48d04740e); broadened to full verification
    

    The real cause is that the paths were redacted before planning. The digest in the message is not something the user can act on.

The documented purpose of --redact-paths is to keep file paths out of the report. Silently running the full suite on every redacted run defeats the purpose of verify's selection.

Question for maintainers: is the widening intended, for example as a deliberately conservative choice under redaction? Some code already turns features off under redaction on purpose (the coverage map and the first pass in executeWithPolicy, and the enforce global-risk fallback). If the widening is intended, the reason should still say that --redact-paths caused it.

DiffCI version

main at 40aa308

Command you ran

A repository with "test": "node --test", src/a.js and src/b.js, test/a.test.js and test/b.test.js (each test imports its own source), and an uncommitted change to src/a.js:

diffci verify --changed --no-checks --json
diffci verify --changed --no-checks --redact-paths --json
Environment

Linux, Node 24, npm.

Output

Without --redact-paths:

"selection": "selected",
"reason": "dependency impact",
"command": "node --test test/a.test.js",
"selected_tests": ["test/a.test.js"]

With --redact-paths:

"selection": "full",
"reason": "selected verification was not executable (node --test would not match 1 selected test file(s), such as 19e48d04740e); broadened to full verification",
"command": "npm test"
What you expected

With --redact-paths, the same selection should run (node --test test/a.test.js), and the receipt should carry digests in place of the paths (selected_tests: ["19e48d04740e"]). If widening under redaction is intended, the reason should say that the selection was widened because of --redact-paths.

Vorherrschende Sprache
TypeScript
Sterne
0
Forks
4
Ø Merge
18 Std. 41 Min.
Gemergte PRs (30 T.)
48

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus DiffCI/core

Alle Issues in DiffCI/core

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.