verify: --redact-paths always widens to the full suite, with a misleading reason

未关闭
#275 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@FredApps 已经在做这个了。

开始于 2026年11月17日。

  • #276 来自 @FredApps —— 未关闭

评估

难度
3/5
预计耗时
1-2 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
领域
ci-cd, testing

调研方向

Start with the observe calls in packages/diffci-cli/src/client/verify.ts, then trace how selectedTests, proposedCommands, and executableSelection are handled in observe.ts and verify.ts. Reproduce the reported --changed --no-checks --redact-paths --json case and inspect the tests covering redacted selection. Done means selected verification stays targeted with redacted paths in the receipt, or any widening clearly reports its redaction cause; pull request #276 is already open.

由索引模型根据 Issue 内容生成。

描述

What went wrong?

diffci verify --redact-paths never runs a selected set of tests. Every redacted run widens to the full suite, and the reason it gives is misleading.

There are two parts:

  1. Every redacted run widens to the full suite. verifyChanged, verifyRange (and verifyScoped, through verifyChangedSnapshot) pass redactPaths to observe (packages/diffci-cli/src/client/verify.ts, the observe({...}) calls in verifyChangedSnapshot and verifyCommitRange). observe then returns selectedTests as sha256-12 digests (observe.ts, selectedTests.map(hashPath)), while proposedCommands still carry the real paths. executableSelection (verify.ts) matches the real command against the digests. unmatchedNodeTests therefore finds that no selected file matches, and the run falls back to the full test command. (For other runners, inferSelectedCommand receives digests in place of paths.)

  2. The reason is misleading. It reads as if the selection could not be expressed as a command:

    selected verification was not executable (node --test would not match 1 selected test file(s), such as 19e48d04740e); broadened to full verification
    

    The real cause is that the paths were redacted before planning. The digest in the message is not something the user can act on.

The documented purpose of --redact-paths is to keep file paths out of the report. Silently running the full suite on every redacted run defeats the purpose of verify's selection.

Question for maintainers: is the widening intended, for example as a deliberately conservative choice under redaction? Some code already turns features off under redaction on purpose (the coverage map and the first pass in executeWithPolicy, and the enforce global-risk fallback). If the widening is intended, the reason should still say that --redact-paths caused it.

DiffCI version

main at 40aa308

Command you ran

A repository with "test": "node --test", src/a.js and src/b.js, test/a.test.js and test/b.test.js (each test imports its own source), and an uncommitted change to src/a.js:

diffci verify --changed --no-checks --json
diffci verify --changed --no-checks --redact-paths --json
Environment

Linux, Node 24, npm.

Output

Without --redact-paths:

"selection": "selected",
"reason": "dependency impact",
"command": "node --test test/a.test.js",
"selected_tests": ["test/a.test.js"]

With --redact-paths:

"selection": "full",
"reason": "selected verification was not executable (node --test would not match 1 selected test file(s), such as 19e48d04740e); broadened to full verification",
"command": "npm test"
What you expected

With --redact-paths, the same selection should run (node --test test/a.test.js), and the receipt should carry digests in place of the paths (selected_tests: ["19e48d04740e"]). If widening under redaction is intended, the reason should say that the selection was widened because of --redact-paths.

主要语言
TypeScript
星标
0
派生
4
平均合并
18 小时 41 分钟
30 天内合并 PR
48

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

DiffCI/core 的其他 Issue

查看 DiffCI/core 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。