verify: --redact-paths always widens to the full suite, with a misleading reason
メンテナーはふだん 1 日以内に返信
評価
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 初心者へのやさしさ
- 35/100
- issue の種類
- バグ
- 明瞭さ
- 明確に書かれている
- 活発さ
- 停滞
- 技術スタック
- node.js, typescript
調査の方向性
Start with the observe calls in packages/diffci-cli/src/client/verify.ts, then trace how selectedTests, proposedCommands, and executableSelection are handled in observe.ts and verify.ts. Reproduce the reported --changed --no-checks --redact-paths --json case and inspect the tests covering redacted selection. Done means selected verification stays targeted with redacted paths in the receipt, or any widening clearly reports its redaction cause; pull request #276 is already open.
索引モデルが issue の本文から書いたものです。
説明
What went wrong?
diffci verify --redact-paths never runs a selected set of tests. Every redacted run widens to the full suite, and the reason it gives is misleading.
There are two parts:
-
Every redacted run widens to the full suite.
verifyChanged,verifyRange(andverifyScoped, throughverifyChangedSnapshot) passredactPathstoobserve(packages/diffci-cli/src/client/verify.ts, theobserve({...})calls inverifyChangedSnapshotandverifyCommitRange).observethen returnsselectedTestsas sha256-12 digests (observe.ts,selectedTests.map(hashPath)), whileproposedCommandsstill carry the real paths.executableSelection(verify.ts) matches the real command against the digests.unmatchedNodeTeststherefore finds that no selected file matches, and the run falls back to the full test command. (For other runners,inferSelectedCommandreceives digests in place of paths.) -
The reason is misleading. It reads as if the selection could not be expressed as a command:
selected verification was not executable (node --test would not match 1 selected test file(s), such as 19e48d04740e); broadened to full verificationThe real cause is that the paths were redacted before planning. The digest in the message is not something the user can act on.
The documented purpose of --redact-paths is to keep file paths out of the report. Silently running the full suite on every redacted run defeats the purpose of verify's selection.
Question for maintainers: is the widening intended, for example as a deliberately conservative choice under redaction? Some code already turns features off under redaction on purpose (the coverage map and the first pass in executeWithPolicy, and the enforce global-risk fallback). If the widening is intended, the reason should still say that --redact-paths caused it.
DiffCI version
main at 40aa308
Command you ran
A repository with "test": "node --test", src/a.js and src/b.js, test/a.test.js and test/b.test.js (each test imports its own source), and an uncommitted change to src/a.js:
diffci verify --changed --no-checks --json
diffci verify --changed --no-checks --redact-paths --json
Environment
Linux, Node 24, npm.
Output
Without --redact-paths:
"selection": "selected",
"reason": "dependency impact",
"command": "node --test test/a.test.js",
"selected_tests": ["test/a.test.js"]
With --redact-paths:
"selection": "full",
"reason": "selected verification was not executable (node --test would not match 1 selected test file(s), such as 19e48d04740e); broadened to full verification",
"command": "npm test"
What you expected
With --redact-paths, the same selection should run (node --test test/a.test.js), and the receipt should carry digests in place of the paths (selected_tests: ["19e48d04740e"]). If widening under redaction is intended, the reason should say that the selection was widened because of --redact-paths.
- 主要言語
- TypeScript
- スター
- 0
- フォーク
- 4
- 平均マージ
- 18時間 41分
- マージ済み PR(30日)
- 48
環境構築
このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
DiffCI/core のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信
-
Planner: splitParts regex is quadratic on a quote followed by many backticks, so the fuzz test fails at random対応中かも @FredApps が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 86/100
メンテナーはふだん 1 日以内に返信
-
Agent tools: changed_files lists only the new path of a renamed file対応中かも @FredApps が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
メンテナーはふだん 1 日以内に返信
-
adapter good first issue
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
メンテナーはふだん 1 日以内に返信
似ている issue
-
agent-ready area: ui-server priority: p3 type: test
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
schlessera/brain-kit#4249 ·
メンテナーはふだん 1 日以内に返信
-
documentation tool triaged
難易度 2/5 1〜3時間 初心者へのやさしさ 73/100
can1357/oh-my-pi#19608 · コメント 2 件 ·
メンテナーはふだん 1 日以内に返信
-
dependencies tech-debt
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
bcgov/nr-waste-plus#1549 ·
メンテナーはふだん 1 日以内に返信
-
enhancement good first issue
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
blixvip/solana-token-meta#17 ·
-
enhancement good first issue
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
blixvip/solana-tx-parse#18 ·