External editor (Ctrl+G): TUI is not hidden before launching editor, causing screen corruption and lost keystrokes

Offen
  • Stimmt etwas nicht?
#1,092 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
66/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
javascript, neovim
Bereich
cli

Rechercherichtung

Start by locating openInEditor and openMemoryFileInEditor, then trace how withLegacyKeyboard wraps the editor spawn without stopping the TUI. Compare that path with the referenced pi pattern: this.tui.stop() before spawning, and this.tui.start() plus this.tui.requestRender(true) in a finally block. Reproduce with cmd, Ctrl+G, and nvim; done means the editor owns the terminal cleanly, keystrokes are not lost, the prompt is captured on return, and the TUI redraws fully.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Summary

When Command Code launches an external editor via Ctrl+G, it does not stop/hide its TUI first. The TUI's render loop (git-polling statusline, autocomplete/snippet UI) keeps writing to the terminal and reading stdin while the editor (e.g. nvim) is running. This causes screen corruption and intermittent keystroke loss (Escape, ZZ), so the prompt is sometimes not captured on return.

This is not specific to the kitty keyboard protocol — it reproduces in wezterm, ghostty, alacritty, and kitty.

Reproduction

  1. Run cmd in any of the terminals above.
  2. Type a prompt, press Ctrl+G to open the external editor (nvim).
  3. Type text, idle ~5s, type more, idle ~5s, then ZZ.
  4. Observe: typed text often does not appear in nvim; ZZ may not register; nvim can hang ("Save and close the editor to continue...").

Evidence (cmd vs pi, side-by-side)

Captured in tmux (same terminal, same nvim config). pi calls tui.stop() before spawning the editor and tui.start() after; cmd does not.

Tool nvim opened typing registered survived idle ZZ exited text captured
pi (reference) YES YES YES YES YES
cmd YES NO (buffer stayed empty) n/a NO (stuck) NO

Root cause

In openInEditor (and openMemoryFileInEditor), cmd wraps the spawn in withLegacyKeyboard, which only pops/pushes the kitty keyboard protocol. It never stops the TUI render loop or stdin handling. Contrast pi:

this.tui.stop();
try {
  let result = await editInExternalEditor({ command, content });
  ...
} finally {
  this.tui.start();
  this.tui.requestRender(true);
}

Because cmd's TUI keeps rendering and reading stdin, keystrokes are consumed and the screen is corrupted while nvim is active.

Suggested fix

Mirror pi: before spawning the external editor, stop the TUI (stop rendering + release stdin); after the editor exits, restart the TUI and request a full render. This is the same pattern opencode uses.

nvim-side mitigations already applied (insufficient)

  • Disabled folke/noice.nvim (fixed nvim freeze on exit after idle).
  • ttimeout = true, ttimeoutlen = 0 (helps Escape registration).

These address nvim-specific issues but cannot fix a parent TUI that keeps writing to the terminal / reading stdin. Screen corruption and text-capture loss remain until cmd hides its TUI.

Environment

  • Command Code v1.88.2
  • nvim 0.12.6
  • Reproduced in wezterm, ghostty, alacritty, kitty
Vorherrschende Sprache
Keine Sprachdaten
Sterne
4.2k
Forks
377
Ø Merge
1 T. 3 Std.
Gemergte PRs (30 T.)
6

Entwicklungsumgebung

Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus CommandCodeAI/command-code

Alle Issues in CommandCodeAI/command-code

Ähnliche Issues

Weitere Issues zu CLI

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.