External editor (Ctrl+G): TUI is not hidden before launching editor, causing screen corruption and lost keystrokes

Aberta
  • Algo errado?
#1,092 1 comentário 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
66/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
javascript, neovim
Domínio
cli

Direção de pesquisa

Start by locating openInEditor and openMemoryFileInEditor, then trace how withLegacyKeyboard wraps the editor spawn without stopping the TUI. Compare that path with the referenced pi pattern: this.tui.stop() before spawning, and this.tui.start() plus this.tui.requestRender(true) in a finally block. Reproduce with cmd, Ctrl+G, and nvim; done means the editor owns the terminal cleanly, keystrokes are not lost, the prompt is captured on return, and the TUI redraws fully.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Summary

When Command Code launches an external editor via Ctrl+G, it does not stop/hide its TUI first. The TUI's render loop (git-polling statusline, autocomplete/snippet UI) keeps writing to the terminal and reading stdin while the editor (e.g. nvim) is running. This causes screen corruption and intermittent keystroke loss (Escape, ZZ), so the prompt is sometimes not captured on return.

This is not specific to the kitty keyboard protocol — it reproduces in wezterm, ghostty, alacritty, and kitty.

Reproduction

  1. Run cmd in any of the terminals above.
  2. Type a prompt, press Ctrl+G to open the external editor (nvim).
  3. Type text, idle ~5s, type more, idle ~5s, then ZZ.
  4. Observe: typed text often does not appear in nvim; ZZ may not register; nvim can hang ("Save and close the editor to continue...").

Evidence (cmd vs pi, side-by-side)

Captured in tmux (same terminal, same nvim config). pi calls tui.stop() before spawning the editor and tui.start() after; cmd does not.

Tool nvim opened typing registered survived idle ZZ exited text captured
pi (reference) YES YES YES YES YES
cmd YES NO (buffer stayed empty) n/a NO (stuck) NO

Root cause

In openInEditor (and openMemoryFileInEditor), cmd wraps the spawn in withLegacyKeyboard, which only pops/pushes the kitty keyboard protocol. It never stops the TUI render loop or stdin handling. Contrast pi:

this.tui.stop();
try {
  let result = await editInExternalEditor({ command, content });
  ...
} finally {
  this.tui.start();
  this.tui.requestRender(true);
}

Because cmd's TUI keeps rendering and reading stdin, keystrokes are consumed and the screen is corrupted while nvim is active.

Suggested fix

Mirror pi: before spawning the external editor, stop the TUI (stop rendering + release stdin); after the editor exits, restart the TUI and request a full render. This is the same pattern opencode uses.

nvim-side mitigations already applied (insufficient)

  • Disabled folke/noice.nvim (fixed nvim freeze on exit after idle).
  • ttimeout = true, ttimeoutlen = 0 (helps Escape registration).

These address nvim-specific issues but cannot fix a parent TUI that keeps writing to the terminal / reading stdin. Screen corruption and text-capture loss remain until cmd hides its TUI.

Environment

  • Command Code v1.88.2
  • nvim 0.12.6
  • Reproduced in wezterm, ghostty, alacritty, kitty
Linguagem predominante
Sem dados de linguagem
Estrelas
4.2k
Forks
377
Merge médio
1d 3h
PRs com merge (30d)
6

Preparar o ambiente

Este projeto não oferece contêiner de desenvolvimento, Dockerfile nem guia de contribuição, então a configuração fica por sua conta: comece pelo README e veja nosso guia da primeira contribuição para os passos gerais.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de CommandCodeAI/command-code

Todas as issues de CommandCodeAI/command-code

Issues semelhantes

Mais issues de CLI

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.