External editor (Ctrl+G): TUI is not hidden before launching editor, causing screen corruption and lost keystrokes

未关闭
  • 哪里不对？
#1,092 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
66/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
javascript, neovim
领域
cli

调研方向

Start by locating openInEditor and openMemoryFileInEditor, then trace how withLegacyKeyboard wraps the editor spawn without stopping the TUI. Compare that path with the referenced pi pattern: this.tui.stop() before spawning, and this.tui.start() plus this.tui.requestRender(true) in a finally block. Reproduce with cmd, Ctrl+G, and nvim; done means the editor owns the terminal cleanly, keystrokes are not lost, the prompt is captured on return, and the TUI redraws fully.

由索引模型根据 Issue 内容生成。

描述

Summary

When Command Code launches an external editor via Ctrl+G, it does not stop/hide its TUI first. The TUI's render loop (git-polling statusline, autocomplete/snippet UI) keeps writing to the terminal and reading stdin while the editor (e.g. nvim) is running. This causes screen corruption and intermittent keystroke loss (Escape, ZZ), so the prompt is sometimes not captured on return.

This is not specific to the kitty keyboard protocol — it reproduces in wezterm, ghostty, alacritty, and kitty.

Reproduction

  1. Run cmd in any of the terminals above.
  2. Type a prompt, press Ctrl+G to open the external editor (nvim).
  3. Type text, idle ~5s, type more, idle ~5s, then ZZ.
  4. Observe: typed text often does not appear in nvim; ZZ may not register; nvim can hang ("Save and close the editor to continue...").

Evidence (cmd vs pi, side-by-side)

Captured in tmux (same terminal, same nvim config). pi calls tui.stop() before spawning the editor and tui.start() after; cmd does not.

Tool nvim opened typing registered survived idle ZZ exited text captured
pi (reference) YES YES YES YES YES
cmd YES NO (buffer stayed empty) n/a NO (stuck) NO

Root cause

In openInEditor (and openMemoryFileInEditor), cmd wraps the spawn in withLegacyKeyboard, which only pops/pushes the kitty keyboard protocol. It never stops the TUI render loop or stdin handling. Contrast pi:

this.tui.stop();
try {
  let result = await editInExternalEditor({ command, content });
  ...
} finally {
  this.tui.start();
  this.tui.requestRender(true);
}

Because cmd's TUI keeps rendering and reading stdin, keystrokes are consumed and the screen is corrupted while nvim is active.

Suggested fix

Mirror pi: before spawning the external editor, stop the TUI (stop rendering + release stdin); after the editor exits, restart the TUI and request a full render. This is the same pattern opencode uses.

nvim-side mitigations already applied (insufficient)

  • Disabled folke/noice.nvim (fixed nvim freeze on exit after idle).
  • ttimeout = true, ttimeoutlen = 0 (helps Escape registration).

These address nvim-specific issues but cannot fix a parent TUI that keeps writing to the terminal / reading stdin. Screen corruption and text-capture loss remain until cmd hides its TUI.

Environment

  • Command Code v1.88.2
  • nvim 0.12.6
  • Reproduced in wezterm, ghostty, alacritty, kitty
主要语言
没有语言数据
星标
4.2k
派生
377
平均合并
1 天 3 小时
30 天内合并 PR
6

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

CommandCodeAI/command-code 的其他 Issue

查看 CommandCodeAI/command-code 的全部 Issue

相似的 Issue

更多 CLI Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。