darnit run --apply can ask twice for one remediation step
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start by reading the remediation safety work on the 043 branch and trace how darnit run --apply obtains approval for plan items and platform change sets. The issue names no files or tests, so locate the relevant approval and digest logic first. Done means approving either side of a plan item made only of change sets approves the other, while high-impact change sets still require individual digest approval.
Written by the indexing model from the issue text.
Description
On the 043 branch, darnit run --apply on a terminal can ask twice for one remediation step: once for the plan item (because the remediation is safe = false) and once for its platform change set (because the [remediation] policy is prompt). The digest rules treat these as separate approvals, but to the person it is the same change.
Proposed: when a plan item's only actions are change sets, approving the plan item approves its change sets, and vice versa. Keep the individual digest requirement for high-impact change sets.
Found while implementing feature 043 (remediation safety, branch 043-remediation-safety, not yet merged).
- Dominant language
- Python
- Stars
- 22
- Forks
- 27
- Avg merge
- 2d 28m
- Merged PRs (30d)
- 40
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from darnitdevorg/darnit
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
darnitdevorg/darnit#589 ·
Maintainers usually reply within 1 day
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
darnitdevorg/darnit#587 ·
Maintainers usually reply within 1 day
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
darnitdevorg/darnit#585 ·
Maintainers usually reply within 1 day
-
quality
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
darnitdevorg/darnit#523 ·
Maintainers usually reply within 1 day
-
documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
darnitdevorg/darnit#516 ·
Maintainers usually reply within 1 day
All issues in darnitdevorg/darnit
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
aws-samples/sample-per-model-bedrock#191 ·
Maintainers usually reply within 1 day
-
area: docs enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
PyTomography/PyTomography#331 ·
Maintainers usually reply within 1 day
-
effort: low prio: low ready
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
digitalfabrik/integreat-cms#4616 ·
Maintainers usually reply within 5 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
FuRongJun-1999/dsh-memory#226 · 1 comment ·
Maintainers usually reply within 1 day
-
bug difficulty:2 good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
MakazhanAlpamys/Soup#1865 ·
Maintainers usually reply within 1 day