Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

test: native save FIFO substitution bound test is flaky under load

Open
  • Is something wrong?
#97 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
rust
Domain
desktop, testing

Research direction

Start with the test fifo_substitution_at_actual_writable_hook_is_bounded in src/document/native_save/unix/tests.rs (around line 988) and the native save code it exercises. Run it in a loop with cargo test -- --test-threads=1 while the CPU is loaded, and look for wall-clock or timing assumptions. Done means the root cause is fixed without simply raising timeouts, with 200 consecutive passes under load and green CI on all three OSes.

Written by the indexing model from the issue text.

Description

area/file-io help wanted type/bug

Problem

document::native_save::unix::tests::fifo_substitution_at_actual_writable_hook_is_bounded (src/document/native_save/unix/tests.rs:988) failed once locally during an unrelated change (Status Line work touching only src/app) and passed on rerun. The machine was under heavy load with a nearly full disk. Likely timing-sensitive.

Why it matters

This test guards the bounded behavior of native save when a FIFO is substituted at the writable hook (a safety property of the atomic save path). A flaky safety test either hides regressions or trains people to rerun until green.

Expected

Deterministic: the bound is enforced by construction (or by a deadline independent of machine load), and the test asserts it without wall-clock sensitivity.

Acceptance

  • Reproduce under load (e.g. run with --test-threads=1 while CPU-saturated, or loop it N times) and record the failure output.
  • Fix the root cause (test timing assumption or production bound), not by raising timeouts blindly.
  • Evidence: 200 consecutive local passes under load plus green CI on all three OSes.
Dominant language
Rust
Stars
4
Forks
2
Avg merge
2h 28m
Merged PRs (30d)
76

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from cristim/AztecCraft

All issues in cristim/AztecCraft

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.